[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] RFR: 8170552: [macosx] Wrong rendering of diacritics on macOS
From: dmitry markov <dmitry.markov () oracle ! com>
Date: 2017-02-15 15:45:14
Message-ID: 58A4778A.3050905 () oracle ! com
[Download RAW message or body]
I have opened JDK-8175025
<https://bugs.openjdk.java.net/browse/JDK-8175025> for that. Will send
review soon.
Thanks,
Dmitry
On 15/02/2017 18:36, Philip Race wrote:
> You are right !
> I missed that. OpenJDK rules rquire it be contributed under GPL v2
> (not classpath)
> The test needs to be updated or deleted ASAP (today would be good).
>
> -phil.
>
> On 2/15/17, 4:47 AM, Sergey Bylokhov wrote:
> > I am not sure, but Is the apache license in the test can be accepted
> > in the openjdk? I had an impression that all code should by under GPL
> > v2 or GPL v2 + the Classpath exception.
> >
> > >
> > > +1
> > >
> > > Vadim
> > >
> > > On 11/02/2017 16:15, dmitry markov wrote:
> > > > Hi Dmitry,
> > > >
> > > > The fix looks good to me too, but I am not a reviewer. So you need
> > > > one more +1 from someone else with reviewer status.
> > > > I will sponsor integration of the fix once it is finally approved.
> > > >
> > > > Thanks,
> > > > Dmitry
> > > > On 11/02/2017 02:48, Phil Race wrote:
> > > > > Looks good to me.
> > > > > It used to be a pain keeping several places in sync, hence the
> > > > > single util function.
> > > > > I guess that pre-dated the Apple code and we didn't realise it had
> > > > > its own copy ..
> > > > > So much code ... so little time ...
> > > > >
> > > > > -phil.
> > > > >
> > > > > On 02/10/2017 01:07 AM, Dmitry Batrak wrote:
> > > > > > Hello,
> > > > > >
> > > > > > I'd like to propose a fix for JDK-8170552.
> > > > > > bug: https://bugs.openjdk.java.net/browse/JDK-8170552
> > > > > > webrev:
> > > > > > http://cr.openjdk.java.net/~dbatrak/8170552/webrev.00/<http://cr.openjdk.java.net/%7Edbatrak/8170552/webrev.00/>
> > > > > >
> > > > > > I don't have a Committer status, so I'll require a sponsor.
> > > > > >
> > > > > > I've proposed this patch earlier via support ticket (it's also
> > > > > > attached to JIRA
> > > > > > issue). It brings the code used to detect complex text when
> > > > > > working with system
> > > > > > fonts on macOS on par with similar code used for other fonts and
> > > > > > platforms.
> > > > > >
> > > > > > As compared to the previously provided patch, I've also added a
> > > > > > test case. It
> > > > > > depends on specifics of the font being used (Menlo), but I
> > > > > > couldn't think of
> > > > > > another way to create an automated test for this issue.
> > > > > >
> > > > > > Best regards,
> > > > > > Dmitry Batrak
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
I have opened <a class="issue-link" data-issue-key="JDK-8175025"
href="https://bugs.openjdk.java.net/browse/JDK-8175025"
id="key-val" rel="4915671">JDK-8175025</a> for that. Will send
review soon.<br>
<br>
Thanks,<br>
Dmitry<br>
<div class="moz-cite-prefix">On 15/02/2017 18:36, Philip Race wrote:<br>
</div>
<blockquote cite="mid:58A4756E.90605@oracle.com" type="cite">You are
right !
<br>
I missed that. OpenJDK rules rquire it be contributed under GPL v2
(not classpath)
<br>
The test needs to be updated or deleted ASAP (today would be
good).
<br>
<br>
-phil.
<br>
<br>
On 2/15/17, 4:47 AM, Sergey Bylokhov wrote:
<br>
<blockquote type="cite">I am not sure, but Is the apache license
in the test can be accepted in the openjdk? I had an impression
that all code should by under GPL v2 or GPL v2 + the Classpath
exception.
<br>
<br>
<blockquote type="cite">
<br>
+1
<br>
<br>
Vadim
<br>
<br>
On 11/02/2017 16:15, dmitry markov wrote:
<br>
<blockquote type="cite">Hi Dmitry,
<br>
<br>
The fix looks good to me too, but I am not a reviewer. So
you need one more +1 from someone else with reviewer status.
<br>
I will sponsor integration of the fix once it is finally
approved.
<br>
<br>
Thanks,
<br>
Dmitry
<br>
On 11/02/2017 02:48, Phil Race wrote:
<br>
<blockquote type="cite">Looks good to me.
<br>
It used to be a pain keeping several places in sync, hence
the single util function.
<br>
I guess that pre-dated the Apple code and we didn't
realise it had its own copy ..
<br>
So much code ... so little time ...
<br>
<br>
-phil.
<br>
<br>
On 02/10/2017 01:07 AM, Dmitry Batrak wrote:
<br>
<blockquote type="cite">Hello,
<br>
<br>
I'd like to propose a fix for JDK-8170552.
<br>
bug: <a class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8170552">https://bugs.openjdk.java.net/browse/JDK-8170552</a>
<br>
webrev:
<a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~dbatrak/8170552/webrev.00/">http://cr.openjdk.java.net/~dbatrak/8170552/webrev.00/</a><a \
class="moz-txt-link-rfc2396E" \
href="http://cr.openjdk.java.net/%7Edbatrak/8170552/webrev.00/"><http://cr.openjdk.java.net/%7Edbatrak/8170552/webrev.00/></a><br>
<br>
I don't have a Committer status, so I'll require a
sponsor.
<br>
<br>
I've proposed this patch earlier via support ticket
(it's also attached to JIRA
<br>
issue). It brings the code used to detect complex text
when working with system
<br>
fonts on macOS on par with similar code used for other
fonts and platforms.
<br>
<br>
As compared to the previously provided patch, I've also
added a test case. It
<br>
depends on specifics of the font being used (Menlo), but
I couldn't think of
<br>
another way to create an automated test for this issue.
<br>
<br>
Best regards,
<br>
Dmitry Batrak
<br>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic