[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9] RFR JDK-8170578: The Pages Range From in print dialog is disabled
From:       Phil Race <philip.race () oracle ! com>
Date:       2016-12-21 17:58:37
Message-ID: 90c7f438-27ee-3334-d91a-5b1aff84e025 () oracle ! com
[Download RAW message or body]

So now I am very suspicious.
First (previous fix I reviewed) Job Sheets weren't supported on 16.10, 
now its PageRanges.

I think this merits investigation of what is going on before we commit 
this fix.
Why are attributes that have always been supported by CUPS suddenly 
unavailable ?

And for the cases we image the pages ourselves, we can implement PageRanges
internally, so for a normal PrinterJob it always can be supported .. 
regardless of
what the printer says.

-phil.


On 12/14/2016 09:50 PM, Prasanta Sadhukhan wrote:
> 
> Hi All,
> 
> Please review a testbug fix for jdk9 for an issue where it it seen 
> that PageRanges option is disabled in printer dialog in ubuntu16.10.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8170578
> 
> webrev: http://cr.openjdk.java.net/~psadhukhan/8170578/webrev.00/
> 
> Issue was, in ubuntu16.10 the attribute map [obtained here 
> http://hg.openjdk.java.net/jdk9/client/jdk/file/dc658d7dde90/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1767]
>  does not have
> "pageranges-supported" attribute returned by CUPS
> so this category is not added to supported categories
> [http://hg.openjdk.java.net/jdk9/client/jdk/file/7f09d558b044/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1030]
>  so isAttributeCategorySupported() called by ServiceDialog returns false
> [http://hg.openjdk.java.net/jdk9/client/jdk/file/7f09d558b044/src/java.desktop/share/classes/sun/print/ServiceDialog.java#l1141]
>  resulting in PageRanges option getting disabled.
> 
> Fix is to check if PageRanges category is supported in underlying 
> platform, only then proceed with the test.
> 
> Regards
> Prasanta


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    So now I am very suspicious.<br>
    First (previous fix I reviewed) Job Sheets weren't supported on
    16.10, now its PageRanges.<br>
    <br>
    I think this merits investigation of what is going on before we
    commit this fix.<br>
    Why are attributes that have always been supported by CUPS suddenly
    unavailable ?<br>
    <br>
    And for the cases we image the pages ourselves, we can implement
    PageRanges<br>
    internally, so for a normal PrinterJob it always can be supported ..
    regardless of<br>
    what the printer says.<br>
    <br>
    -phil.<br>
    <br>
    <br>
    <div class="moz-cite-prefix">On 12/14/2016 09:50 PM, Prasanta
      Sadhukhan wrote:<br>
    </div>
    <blockquote
      cite="mid:39f21e6d-78fb-6486-0260-620f42a63ccb@oracle.com"
      type="cite">
      <meta http-equiv="content-type" content="text/html; charset=utf-8">
      <p>Hi All,</p>
      <p>Please review a testbug fix for jdk9 for an issue where it it
        seen that PageRanges option is disabled in printer dialog in
        ubuntu16.10.</p>
      <p>Bug: <a moz-do-not-send="true" class="moz-txt-link-freetext"
          href="https://bugs.openjdk.java.net/browse/JDK-8170578">https://bugs.openjdk.java.net/browse/JDK-8170578</a></p>
  <p>webrev: <a moz-do-not-send="true"
          class="moz-txt-link-freetext"
          href="http://cr.openjdk.java.net/%7Epsadhukhan/8170578/webrev.00/">http://cr.openjdk.java.net/~psadhukhan/8170578/webrev.00/</a></p>
  Issue was, in ubuntu16.10 the attribute map [obtained here
      <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk9/client/jdk/file/dc658d7dde90/src/java.desktop/un \
ix/classes/sun/print/IPPPrintService.java#l1767">http://hg.openjdk.java.net/jdk9/clien \
t/jdk/file/dc658d7dde90/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1767</a>]<br>
  does not have<br>
      "pageranges-supported" attribute returned by CUPS<br>
      so this category is not added to supported categories<br>
      [<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk9/client/jdk/file/7f09d558b044/src/java.desktop/un \
ix/classes/sun/print/IPPPrintService.java#l1030">http://hg.openjdk.java.net/jdk9/clien \
t/jdk/file/7f09d558b044/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1030</a>]<br>
  so isAttributeCategorySupported() called by ServiceDialog returns
      false<br>
      [<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk9/client/jdk/file/7f09d558b044/src/java.desktop/sh \
are/classes/sun/print/ServiceDialog.java#l2763">http://hg.openjdk.java.net/jdk9/client \
/jdk/file/7f09d558b044/src/java.desktop/share/classes/sun/print/ServiceDialog.java#l1141</a>]<br>
  resulting in PageRanges option getting disabled.<br>
      <br>
      Fix is to check if PageRanges category is supported in underlying
      platform, only then proceed with the test.<br>
      <br>
      Regards<br>
      Prasanta<br>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic