[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR 8160888: [PIT] What to expect of updated java/awt/print/PrinterJob/Marg
From: Philip Race <philip.race () oracle ! com>
Date: 2016-11-08 0:18:28
Message-ID: 582119D4.3050609 () oracle ! com
[Download RAW message or body]
+1 although ...
* ie ix=72 iy=72 iw=451 ih=697 and paper wid=595
that's an "eg" not an "ie"
-phil.
On 11/7/16, 2:28 AM, Prasanta Sadhukhan wrote:
>
> Please find the modified webrev taking care of the suggested changes
>
> http://cr.openjdk.java.net/~psadhukhan/8160888/webrev.02/
>
> Regards
> Prasanta
> On 11/5/2016 12:13 AM, Phil Race wrote:
>> 80 aset.add(MediaSizeName.ISO_A4);
>> Why ? You can't require that as not everyone has A4 paper handy.
>>
>> @requires (os.family == "windows")
>> You are excluding Mac which you say works fine. Why ?
>>
>>
>> For Linux (or maybe all platforms)I suggest runtime checking to see if the
>> margins/printable area correspond to the entire size of the paper and treat it with suspicion ..
>> in that case you could skip the actual test - like an automatic pass.
>>
>> -phil.
>> On 07/19/2016 10:33 PM, Prasanta Sadhukhan wrote:
>>> I have updated the webrev to remove run only on windows jtreg tag as
>>> with the fix proposed for
>>> 6574279: validatePage from PrinterJob returns argument under linux
>>> the printed margin will be of correct value and not the full
>>> imageablearea(0,0,paperwidth,paperheight)
>>> so the issue will be seen on windows & linux without 6601097
>>> <https://bugs.openjdk.java.net/browse/JDK-6601097> fix and not after
>>> applying 6601097 <https://bugs.openjdk.java.net/browse/JDK-6601097>.
>>> Issue is still not reproducible in mac which prints with correct
>>> hardware margin without 6601097
>>> <https://bugs.openjdk.java.net/browse/JDK-6601097> fix.
>>>
>>> http://cr.openjdk.java.net/~psadhukhan/8160888/webrev.01/
>>>
>>> Regards
>>> Prasanta
>>> On 7/8/2016 12:59 PM, Prasanta Sadhukhan wrote:
>>>> Hi All,
>>>>
>>>> Please find an updation of the testcase
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8160888
>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8160888/webrev.00/
>>>>
>>>> where the testcase was made automated and
>>>> specifically pass mediasize=A4 as attributes so that there is no
>>>> ambiguity of using "letter" vs "A4".
>>>> Also, the test is made to run only on windows as the bug is not
>>>> reproduced in linux/mac.
>>>>
>>>> Regards
>>>> Prasanta
>>>
>>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
+1 although ...<br>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<pre><span class="changed"> * ie ix=72 iy=72 iw=451 ih=697 and paper wid=595
that's an "eg" not an "ie"
-phil.
</span></pre>
On 11/7/16, 2:28 AM, Prasanta Sadhukhan wrote:
<blockquote
cite="mid:dd63f66e-9f0f-111a-e491-b68151927090@oracle.com"
type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<p>Please find the modified webrev taking care of the suggested
changes<br>
</p>
<p><a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Epsadhukhan/8160888/webrev.02/">http://cr.openjdk.java.net/~psadhukhan/8160888/webrev.02/</a><br>
</p>
Regards<br>
Prasanta<br>
<div class="moz-cite-prefix">On 11/5/2016 12:13 AM, Phil Race
wrote:<br>
</div>
<blockquote
cite="mid:ac9b926f-3ee1-8ee9-5e28-1b0c03b11d23@oracle.com"
type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
<pre><span class="new"> 80 \
aset.add(MediaSizeName.ISO_A4);</span></pre>
Why ? You can't require that as not everyone has A4 paper handy.<br>
<br>
<pre><span class="changed">@requires (os.family == "windows")</span>
</pre>
<pre><span class="changed"><span class="changed">You are excluding Mac which \
you say works fine. Why ?
For Linux (or maybe all platforms) </span>I</span><span class="changed"> suggest \
runtime checking to see if the margins/printable area correspond to the entire size \
of the paper and treat it with suspicion .. in that case you could skip the actual \
test - like an automatic pass.
-phil.
</span></pre>
<span class="changed"></span>
<div class="moz-cite-prefix">On 07/19/2016 10:33 PM, Prasanta
Sadhukhan wrote:<br>
</div>
<blockquote cite="mid:578F0D2A.4040006@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
I have updated the webrev to remove run only on windows jtreg
tag as with the fix proposed for <br>
6574279: validatePage from PrinterJob returns argument under
linux<br>
the printed margin will be of correct value and not the full
imageablearea(0,0,paperwidth,paperheight)<br>
so the issue will be seen on windows & linux without <a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-6601097"
style="color: #3b73af; text-decoration: none">6601097</a>
fix and not after applying <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-6601097"
style="color: #3b73af; text-decoration: none">6601097</a>.
Issue is still not reproducible in mac which prints with
correct hardware margin without <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-6601097"
style="color: #3b73af; text-decoration: none">6601097</a>
fix.<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Epsadhukhan/8160888/webrev.01/">http://cr.openjdk.java.net/~psadhukhan/8160888/webrev.01/</a><br>
<br>
Regards<br>
Prasanta<br>
<div class="moz-cite-prefix">On 7/8/2016 12:59 PM, Prasanta
Sadhukhan wrote:<br>
</div>
<blockquote cite="mid:577F5653.1010500@oracle.com" type="cite">Hi
All, <br>
<br>
Please find an updation of the testcase <br>
<br>
Bug: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8160888">https://bugs.openjdk.java.net/browse/JDK-8160888</a>
<br>
webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Epsadhukhan/8160888/webrev.00/">http://cr.openjdk.java.net/~psadhukhan/8160888/webrev.00/</a>
<br>
<br>
where the testcase was made automated and <br>
specifically pass mediasize=A4 as attributes so that there
is no ambiguity of using "letter" vs "A4". <br>
Also, the test is made to run only on windows as the bug is
not reproduced in linux/mac. <br>
<br>
Regards <br>
Prasanta <br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic