[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9] RFR JDK-8164750: TIFF reading fails when ignoring metadata with BaselineTIF
From:       Phil Race <philip.race () oracle ! com>
Date:       2016-11-01 19:22:18
Message-ID: f2cf548c-bef0-08da-e668-b57175cb56ce () oracle ! com
[Download RAW message or body]

Hi,

I had to do a bit of back-tracing of the source to confirm that
ignoreUnknownFields is initialised from the value of ignoreMetadata.

+1

-phil.

On 10/26/2016 01:05 PM, Brian Burkhalter wrote:
> Please review at your convenience:
> 
> Issue:	https://bugs.openjdk.java.net/browse/JDK-8164750
> Patch:	http://cr.openjdk.java.net/~bpb/8164750/webrev.00/
> 
> Currently if ignoreMetadata == true and the set of allowed TIFFTagSets does not \
> contain the BaselineTIFFTagSet instance then image reading will fail as fields \
> essential to reading and interpreting the data will be ignored. 
> Thanks,
> 
> Brian
> 
> 


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=windows-1252"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Hi,<br>
    <br>
    I had to do a bit of back-tracing of the source to confirm that<span
      class="new"><br>
      ignoreUnknownFields is initialised from the value of
      ignoreMetadata.</span><br>
    <br>
    +1<br>
    <br>
    -phil.<br>
    <br>
    <div class="moz-cite-prefix">On 10/26/2016 01:05 PM, Brian
      Burkhalter wrote:<br>
    </div>
    <blockquote
      cite="mid:06829A48-EE85-48B8-B48F-8782C40FD183@oracle.com"
      type="cite">
      <pre wrap="">Please review at your convenience:

Issue:	<a class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8164750">https://bugs.openjdk.java.net/browse/JDK-8164750</a>
                
Patch:	<a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~bpb/8164750/webrev.00/">http://cr.openjdk.java.net/~bpb/8164750/webrev.00/</a>


Currently if ignoreMetadata == true and the set of allowed TIFFTagSets does not \
contain the BaselineTIFFTagSet instance then image reading will fail as fields \
essential to reading and interpreting the data will be ignored.

Thanks,

Brian


</pre>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic