[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168498: ExifGPSTagSet and ExifTIFFTagSet should use string literal
From: Phil Race <philip.race () oracle ! com>
Date: 2016-10-24 19:52:36
Message-ID: d543a799-4f3b-aa5f-d937-17b7a1beb512 () oracle ! com
[Download RAW message or body]
+1
-phil
On 10/24/2016 12:49 PM, Brian Burkhalter wrote:
> Updating to simply use a double-quoted string instead of a
> concatenation of chars.
>
> Thanks,
>
> Brian
>
> On Oct 21, 2016, at 12:18 PM, Brian Burkhalter
> <brian.burkhalter@oracle.com <mailto:brian.burkhalter@oracle.com>> wrote:
>
>> Please review this trivial change at your convenience:
>>
>> Issue:https://bugs.openjdk.java.net/browse/JDK-8168498
>> Patch:[1]
>
> [1] diff
>
> ---
> a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifGPSTagSet.java
> +++
> b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifGPSTagSet.java
> @@ -55,9 +55,7 @@
> *
> * @see #TAG_GPS_VERSION_ID
> */
> - public static final String GPS_VERSION_2_2 =
> - new String(new byte[] { '2', '2', '0', '0' },
> - StandardCharsets.US_ASCII);
> + public static final String GPS_VERSION_2_2 = "2200";
>
>
> ---
> a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifTIFFTagSet.java
> +++
> b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifTIFFTagSet.java
> @@ -71,9 +71,7 @@
> *
> * @see #TAG_EXIF_VERSION
> */
> - public static final String EXIF_VERSION_2_1 =
> - new String(new byte[] { '0', '2', '1', '0' },
> - StandardCharsets.US_ASCII);
> + public static final String EXIF_VERSION_2_1 = "0210";
>
>
> @@ -82,9 +80,7 @@
> *
> * @see #TAG_EXIF_VERSION
> */
> - public static final String EXIF_VERSION_2_2 =
> - new String(new byte[] { '0', '2', '2', '0' },
> - StandardCharsets.US_ASCII);
> + public static final String EXIF_VERSION_2_2 = "0220";
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
+1<br>
<br>
-phil<br>
<br>
<div class="moz-cite-prefix">On 10/24/2016 12:49 PM, Brian
Burkhalter wrote:<br>
</div>
<blockquote
cite="mid:0C84F95A-59C1-486C-AD6D-7A8F1C38275E@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
Updating to simply use a double-quoted string instead of a
concatenation of chars.
<div><br>
</div>
<div>Thanks,</div>
<div><br>
</div>
<div>Brian</div>
<div><br>
<div>
<div>On Oct 21, 2016, at 12:18 PM, Brian Burkhalter <<a
moz-do-not-send="true"
href="mailto:brian.burkhalter@oracle.com">brian.burkhalter@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite"><span style="font-family: Helvetica;
font-size: 12px; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal; line-height:
normal; orphans: auto; text-align: start; text-indent:
0px; text-transform: none; white-space: normal; widows:
auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;
float: none; display: inline !important;">Please review
this trivial change at your convenience:</span>
<div style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; line-height: normal;
orphans: auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows: auto;
word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>
</div>
<div style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; line-height: normal;
orphans: auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows: auto;
word-spacing: 0px; -webkit-text-stroke-width: 0px;">Issue:<span \
class="Apple-tab-span" style="white-space: pre;"> </span><a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8168498">https://bugs.openjdk.java.net/browse/JDK-8168498</a></div>
<div style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; line-height: normal;
orphans: auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows: auto;
word-spacing: 0px; -webkit-text-stroke-width: 0px;">Patch:<span \
class="Apple-tab-span" style="white-space: pre;"> </span>[1]</div> </blockquote>
</div>
<br>
<div>[1] diff</div>
<div><br>
</div>
<div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">---
a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifGPSTagSet.java</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">+++
b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifGPSTagSet.java</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">@@ -55,9 +55,7 @@</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';"> *</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';"> * @see #TAG_GPS_VERSION_ID</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';"> */</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">- public static final String
GPS_VERSION_2_2 =</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">- new String(new byte[] { '2', '2',
'0', '0' },</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">- StandardCharsets.US_ASCII);</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">+ public static final String
GPS_VERSION_2_2 = "2200";</div>
<p style="margin: 0px; font-size: 11px; font-family: 'Courier
New'; min-height: 12px;"> <br
class="webkit-block-placeholder">
</p>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">---
a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifTIFFTagSet.java</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">+++
b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifTIFFTagSet.java</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">@@ -71,9 +71,7 @@</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';"> *</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';"> * @see #TAG_EXIF_VERSION</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';"> */</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">- public static final String
EXIF_VERSION_2_1 =</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">- new String(new byte[] { '0', '2',
'1', '0' },</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">- StandardCharsets.US_ASCII);</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">+ public static final String
EXIF_VERSION_2_1 = "0210";</div>
<p style="margin: 0px; font-size: 11px; font-family: 'Courier
New'; min-height: 12px;"> <br
class="webkit-block-placeholder">
</p>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">@@ -82,9 +80,7 @@</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';"> *</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';"> * @see #TAG_EXIF_VERSION</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';"> */</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">- public static final String
EXIF_VERSION_2_2 =</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">- new String(new byte[] { '0', '2',
'2', '0' },</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">- StandardCharsets.US_ASCII);</div>
<div style="margin: 0px; font-size: 11px; font-family:
'Courier New';">+ public static final String
EXIF_VERSION_2_2 = "0220";</div>
</div>
<div><br>
</div>
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic