[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9] RFR JDK-8167281: IIOMetadataNode bugs in getElementsByTagName and NodeList.
From:       Jayathirth D V <jayathirth.d.v () oracle ! com>
Date:       2016-10-17 7:42:35
Message-ID: 24a22501-4404-43db-9539-a5ca595a7335 () default
[Download RAW message or body]

Hi Phil & Prahalad,

FYI.
There was trailing space at line 885. I have removed the trailing space and checked \
in following webrev : http://cr.openjdk.java.net/~jdv/8167281/webrev.01/ 

Thanks,
Jay

-----Original Message-----
From: Prahalad Kumar Narayanan 
Sent: Friday, October 14, 2016 11:49 AM
To: Jayathirth D V; Ajit Ghaisas; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8167281: IIOMetadataNode bugs in \
getElementsByTagName and NodeList.item methods

The change looks good. +1

- Prahalad N.

> From: Phil Race 
> Sent: Wednesday, October 12, 2016 10:28 PM
> To: Jayathirth D V; 2d-dev
> Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8167281: IIOMetadataNode bugs in \
> getElementsByTagName and NodeList.item methods 
> Looks fine to me.
> 
> -phil.
> 
> > On 10/07/2016 01:48 AM, Jayathirth D V wrote:
> > Hi,
> > 
> > Please review the following fix in JDK9 at your convenience:
> > 
> > Bug : https://bugs.openjdk.java.net/browse/JDK-8167281 
> > 
> > Webrev : http://cr.openjdk.java.net/~jdv/8167281/webrev.00/ 
> > 
> > Issue : IIONodeList.item(index) and IIOMetadataNode. getElementsByTagName(tag) \
> > are not following specification properly. 
> > Root cause : . IIOMetadataNode .getElementsByTagName(tag) returns empty list for \
> > special input value "*" and IIONodeList.item(index)throws \
> > IndexOutOfBoundsException for index >>equal to length of NodeList. 
> > Solution : IIOMetadataNode .getElementsByTagName(tag) should match all tags for \
> > special input value "*" and IIONodeList.item(index) should return null if input \
> > index is equals to >>length >of NodeList. 
> > Thanks,
> > Jay


[prev in list] [next in list] [prev in thread] [next in thread]