[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] Request for Review: JDK-8162591 All existing gradient paint implementations hav
From:       Phil Race <philip.race () oracle ! com>
Date:       2016-09-30 18:46:35
Message-ID: 3173eea3-beff-1752-7192-f20ad38e9370 () oracle ! com
[Download RAW message or body]

Pushed ..

-phil.

On 09/28/2016 12:41 PM, Sergey Bylokhov wrote:
> Thanks.
>
> On 28.09.16 8:45, Clemens Eisserer wrote:
>> HI Jim,
>>
>>> All of those conditions are optimized equivalents to getting the
>>> determinant.
>>>
>>> invert() is a destructive call, but since getTransform is documented to
>>> return a copy, that is fine - but getDeterminant() will involve less 
>>> math to
>>> check the condition...
>>
>> Thanks for the clarification.
>>
>> Please find the latest version of the patch at
>> http://93.83.133.214/8162591/webrev.04/ - where catching the Exception
>> has been replaced with a != 0.0 check against the determinant. Please
>> commit  in case no further issues are found.
>>
>> Best regards, Clemens
>>
>
>

[prev in list] [next in list] [prev in thread] [next in thread]