[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8166685: We should unpin stream and pixel buffer in case of setjmp
From: Philip Race <philip.race () oracle ! com>
Date: 2016-09-28 17:16:42
Message-ID: 57EBFAFA.6040804 () oracle ! com
[Download RAW message or body]
+1
-phil.
On 9/26/16, 12:35 AM, Jayathirth D V wrote:
>
> Hi,
>
> Please review the following fix in JDK9 at your convenience:
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8166685
>
> Webrev : http://cr.openjdk.java.net/~jdv/8166685/webrev.00/
> <http://cr.openjdk.java.net/%7Ejdv/8166685/webrev.00/>
>
> Issue : As part of fix for JDK- 8162461 we removed RELEASE_ARRAYS() in
> writeImage() call in imageioJPEG.c for setjmp case.
>
> Root cause : We can perform non-local jump to setjmp from longjmp
> during anytime in write process. If there is no RELEASE_ARRAYS() call
> then it might crash JVM as it was happening in JDK- 8162461.
>
> Solution : We should have RELEASE_ARRAYS() call in setjmp case for
> writeImage() in imageioJPEG.c.
>
> Thanks,
>
> Jay
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
+1<br>
<br>
-phil.<br>
<br>
On 9/26/16, 12:35 AM, Jayathirth D V wrote:
<blockquote cite="mid:8f926014-20e8-4884-a3c5-0de30b0eaf6b@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please review the following fix in JDK9 at
your convenience:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Bug : <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8166685">https://bugs.openjdk.java.net/browse/JDK-8166685</a>
<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Webrev : <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ejdv/8166685/webrev.00/">http://cr.openjdk.java.net/~jdv/8166685/webrev.00/</a>
<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Issue : As part of fix for JDK- 8162461 we
removed RELEASE_ARRAYS() in writeImage() call in imageioJPEG.c
for setjmp case.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Root cause : We can perform non-local jump
to setjmp from longjmp during anytime in write process. If
there is no RELEASE_ARRAYS() call then it might crash JVM as
it was happening in JDK- 8162461.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Solution : We should have RELEASE_ARRAYS()
call in setjmp case for writeImage() in imageioJPEG.c.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Jay<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</blockquote>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic