[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8154075: [TIFF] AIOOB Exception from TIFFLZWDecompressor
From: Phil Race <philip.race () oracle ! com>
Date: 2016-09-02 17:09:08
Message-ID: 57C9B234.40203 () oracle ! com
[Download RAW message or body]
+1
-phil.
On 09/02/2016 07:59 AM, Brian Burkhalter wrote:
> Here is a somewhat less inane version:
>
> http://cr.openjdk.java.net/~bpb/8154075/webrev.01/
> <http://cr.openjdk.java.net/%7Ebpb/8154075/webrev.01/>
>
> All the same tests still pass.
>
> Thanks,
>
> Brian
>
> On Sep 1, 2016, at 1:37 PM, Brian Burkhalter
> <brian.burkhalter@oracle.com <mailto:brian.burkhalter@oracle.com>> wrote:
>
>> I did not notice that. It is indeed bizarre. I was trying to take
>> some calculations outside the loops to obtain a small performance
>> improvement and did not notice the name transposition. I’ll update it.
>>
>> Thanks,
>>
>> Brian
>>
>> On Sep 1, 2016, at 1:27 PM, Phil Race <philip.race@oracle.com
>> <mailto:philip.race@oracle.com>> wrote:
>>
>>> 168 int gain = step * srcWidth;
>>> 169 int bound = srcWidth * step;
>>>
>>> This looks odd. Is it what you meant ?
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">+1<br>
<br>
-phil.<br>
<br>
On 09/02/2016 07:59 AM, Brian Burkhalter wrote:<br>
</div>
<blockquote
cite="mid:1A2E4943-E2AF-4C4E-8EC4-9EBA8807E96D@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
Here is a somewhat less inane version:
<div><br>
</div>
<div><a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ebpb/8154075/webrev.01/">http://cr.openjdk.java.net/~bpb/8154075/webrev.01/</a></div>
<div><br>
</div>
<div>All the same tests still pass.</div>
<div><br>
</div>
<div>Thanks,</div>
<div><br>
</div>
<div>Brian</div>
<div><br>
<div>
<div>On Sep 1, 2016, at 1:37 PM, Brian Burkhalter <<a
moz-do-not-send="true"
href="mailto:brian.burkhalter@oracle.com">brian.burkhalter@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space;
-webkit-line-break: after-white-space;">I did not notice
that. It is indeed bizarre. I was trying to take some
calculations outside the loops to obtain a small
performance improvement and did not notice the name
transposition. I’ll update it.
<div><br>
</div>
<div>Thanks,</div>
<div><br>
</div>
<div>Brian</div>
<div><br>
<div>
<div>On Sep 1, 2016, at 1:27 PM, Phil Race <<a
moz-do-not-send="true"
\
href="mailto:philip.race@oracle.com">philip.race@oracle.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite"><span style="font-family:
Helvetica; font-size: 12px; font-style: normal;
font-variant: normal; font-weight: normal;
letter-spacing: normal; line-height: normal;
orphans: auto; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px; float: none;
display: inline !important;">168 int
gain = step * srcWidth;</span><br
style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal;
line-height: normal; orphans: auto; text-align:
start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px;">
<span style="font-family: Helvetica; font-size:
12px; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal;
line-height: normal; orphans: auto; text-align:
start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; float: none;
display: inline !important;">169 int
bound = srcWidth * step;</span><br
style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal;
line-height: normal; orphans: auto; text-align:
start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px;">
<br style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal;
line-height: normal; orphans: auto; text-align:
start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px;">
<span style="font-family: Helvetica; font-size:
12px; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal;
line-height: normal; orphans: auto; text-align:
start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; float: none;
display: inline !important;">This looks odd. Is it
what you meant ?</span><br style="font-family:
Helvetica; font-size: 12px; font-style: normal;
font-variant: normal; font-weight: normal;
letter-spacing: normal; line-height: normal;
orphans: auto; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px;">
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic