[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR 4885375: Page Ranges 'To Page' field must be populated based on Pageabl
From: Jayathirth D V <jayathirth.d.v () oracle ! com>
Date: 2016-09-01 7:37:23
Message-ID: b293f264-5dcd-4ca3-887d-4f75b9dcd577 () default
[Download RAW message or body]
Hi Prasanta,
Changes are working fine.
Thanks,
Jay
From: Philip Race
Sent: Wednesday, August 24, 2016 11:12 PM
To: Prasanta Sadhukhan
Cc: 2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR 4885375: Page Ranges 'To Page' field must be \
populated based on Pageable
OK that is what I (sort of) suspected.
+1
-phil.
On 8/24/16, 10:08 AM, Prasanta Sadhukhan wrote:
Modified testcase
HYPERLINK "http://cr.openjdk.java.net/%7Epsadhukhan/4885375/webrev.01/"http://cr.openjdk.java.net/~psadhukhan/4885375/webrev.01/
On 8/24/2016 10:27 PM, Prasanta Sadhukhan wrote:
Oh, it should be return 5. I was testing the 2nd issue and forgot to change it back.
Regards
Prasanta
On 8/24/2016 10:26 PM, Philip Race wrote:
Why does the test look like this ?
157 @Override
158 public int getNumberOfPages() {
159 return 0;
160 }
-phil.
On 8/23/16, 5:05 AM, Prasanta Sadhukhan wrote:
Hi All,
Please review a fix whereby it is seen that Page Ranges fields in the \
"cross-platform" dialog does not get populated based on what pageable's \
getNumberOfPages() returns. "To" field is always 1. However, for native dialog it \
shows the "To" field correctly based on what getNumberOfPages() returns.
Bug: https://bugs.openjdk.java.net/browse/JDK-4885375
webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epsadhukhan/4885375/webrev.00/"http://cr.openjdk.java.net/~psadhukhan/4885375/webrev.00/ \
This is because in cross platform ServiceDialog, for the ToPage to get populated, \
PageRanges should be present in the attribute set. In this case, there is no \
PageRanges so it defaults to "from 1 to 1" pages. Proposed fix is to set a PageRange \
attribute to be from 1 to getNumberOfPages.
The 2nd issue of disabling PageRange fields if getNumberOfPages() returns 0 is not \
handled as there is no provision of passing PageRanges 0 to ServiceDialog (it resuls \
in IAE).
Regards
Prasanta
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-US link=blue \
vlink=purple><div class=WordSection1><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Hi \
Prasanta,<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Changes are \
working fine.<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Thanks,<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Jay<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><div><div \
style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p \
class=MsoNormal><b><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext'>From:</span></b><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext'> Philip \
Race <br><b>Sent:</b> Wednesday, August 24, 2016 11:12 PM<br><b>To:</b> Prasanta \
Sadhukhan<br><b>Cc:</b> 2d-dev<br><b>Subject:</b> Re: [OpenJDK 2D-Dev] [9] RFR \
4885375: Page Ranges 'To Page' field must be populated based on \
Pageable<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal>OK that is what I (sort of) \
suspected.<br><br>+1<br><br>-phil.<br><br>On 8/24/16, 10:08 AM, Prasanta Sadhukhan \
wrote: <o:p></o:p></p><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p \
class=MsoNormal style='margin-bottom:12.0pt'>Modified testcase<br><a \
href="http://cr.openjdk.java.net/%7Epsadhukhan/4885375/webrev.01/">http://cr.openjdk.java.net/~psadhukhan/4885375/webrev.01/</a><o:p></o:p></p><div><p \
class=MsoNormal>On 8/24/2016 10:27 PM, Prasanta Sadhukhan \
wrote:<o:p></o:p></p></div><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal>Oh, it should be \
return 5. I was testing the 2nd issue and forgot to change it \
back.<br><br>Regards<br>Prasanta<o:p></o:p></p><div><p class=MsoNormal>On 8/24/2016 \
10:26 PM, Philip Race wrote:<o:p></o:p></p></div><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal>Why does the test \
look like this ?<o:p></o:p></p><pre> 157 @Override<o:p></o:p></pre><pre> 158 \
public int getNumberOfPages() {<o:p></o:p></pre><pre> 159 return \
0;<o:p></o:p></pre><pre> 160 \
}<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>-phil.<o:p></o:p></pre><p \
class=MsoNormal><br>On 8/23/16, 5:05 AM, Prasanta Sadhukhan wrote: \
<o:p></o:p></p><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p \
class=MsoNormal>Hi All, <br><br>Please review a fix whereby it is seen that Page \
Ranges fields in the "cross-platform" dialog does not get populated based \
on what pageable's getNumberOfPages() returns. "To" field is always 1. \
<br>However, for native dialog it shows the "To" field correctly based on \
what getNumberOfPages() returns. <br><br>Bug: <a \
href="https://bugs.openjdk.java.net/browse/JDK-4885375">https://bugs.openjdk.java.net/browse/JDK-4885375</a> \
<br>webrev: <a href="http://cr.openjdk.java.net/%7Epsadhukhan/4885375/webrev.00/">http://cr.openjdk.java.net/~psadhukhan/4885375/webrev.00/</a> \
<br><br>This is because in cross platform ServiceDialog, for the ToPage to get \
populated, PageRanges should be present in the attribute set. In this case, there is \
no PageRanges so it defaults to "from 1 to 1" pages. <br>Proposed fix is to \
set a PageRange attribute to be from 1 to getNumberOfPages. <br><br>The 2nd issue of \
disabling PageRange fields if getNumberOfPages() returns 0 is not handled as there is \
no provision of passing PageRanges 0 to ServiceDialog (it resuls in IAE). \
<br><br>Regards <br>Prasanta <o:p></o:p></p></blockquote></blockquote><p \
class=MsoNormal><o:p> </o:p></p></blockquote><p \
class=MsoNormal><o:p> </o:p></p></blockquote></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic