[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide in
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2016-08-24 15:09:19
Message-ID: 7ee4be70-3108-79b4-71b6-86cc1a3c98ea () oracle ! com
[Download RAW message or body]

+1

On 24.08.16 3:49, Brian Burkhalter wrote:
> OK unless there are objections from Sergey tomorrow I will plan to push
> it as-is.
>
> Thanks,
>
> Brian
>
> On Aug 23, 2016, at 5:12 PM, Philip Race <philip.race@oracle.com
> <mailto:philip.race@oracle.com>> wrote:
>
>> Still fine with me.
>>
>> -phil.
>>
>> On 8/23/16, 4:18 PM, Brian Burkhalter wrote:
>>> Hi Sergey,
>>>
>>> I have added some comments in both the source and the test:
>>>
>>> http://cr.openjdk.java.net/~bpb/8149562/webrev.03/
>>> <http://cr.openjdk.java.net/%7Ebpb/8149562/webrev.03/>
>>>
>>> Please indicate whether you think this is sufficient. The CCC request
>>> has been approved therefore pushing this code is pending only review
>>> approval.
>>>
>>> Thanks,
>>>
>>> Brian
>>>
>>> On Aug 23, 2016, at 11:45 AM, Sergey Bylokhov
>>> <Sergey.Bylokhov@oracle.com <mailto:Sergey.Bylokhov@oracle.com>> wrote:
>>>
>>>> On 23.08.16 21:41, Sergey Bylokhov wrote:
>>>>> Is it possible, just for the record, to provide a comment why NPE was
>>>>> changed to IAE.
>>>> I meant the first check node==null.
>>>>
>>>> actually this code looks a little bit strange:
>>>>> 493         } catch (NullPointerException npe) {
>>>>> 494             throw new IllegalArgumentException(npe);
>>>>> 495         }
>>>
>


-- 
Best regards, Sergey.
[prev in list] [next in list] [prev in thread] [next in thread]