[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8139176: [macosx] java.awt.TextLayout does not handle correctly the bolded
From:       Vadim Pakhnushev <vadim.pakhnushev () oracle ! com>
Date:       2016-08-23 13:01:34
Message-ID: 30247858-0c71-006d-67ed-cde9d85305bc () oracle ! com
[Download RAW message or body]

+1

Vadim

On 21.08.2016 21:31, Philip Race wrote:
> Thanks Sergey .. I am still waiting for a 2nd +1 from someone else.
>
> -phil.
>
> On 8/12/16, 12:28 PM, Sergey Bylokhov wrote:
>> Looks fine.
>>
>> On 12.08.16 20:15, Philip Race wrote:
>>> Updated test : http://cr.openjdk.java.net/~prr/8139176.1/
>>>
>>> -phil.
>>>
>>> On 8/12/16, 10:11 AM, Philip Race wrote:
>>>>
>>>>
>>>> On 8/12/16, 5:48 AM, Sergey Bylokhov wrote:
>>>>> Hi, Phil.
>>>>> A few comments about the test:
>>>>>  - jtreg can stop the test at the end of the main, before invokeLater
>>>>> will start/complete.(on my system it always pass because of that)
>>>>
>>>> hmm. The only reason this test shows a window is to be helpful to 
>>>> humans.
>>>> I think I'll make jtreg just draw to a BI and the UI only be there for
>>>> the "interactive" mode
>>>> which is meant to be used outside jtreg.
>>>> That will dispense with (get rid of) the need for @headful too.
>>>>
>>>>>  - The frame should be disposed at the end of the test.
>>>> OK .. perhaps also non-essential if I make the above change
>>>>>  - Probably the correct location of the test is
>>>>> java/awt/font/TextLayout/?
>>>>
>>>> OK.
>>>>
>>>> I will tweak the test and resubmit shortly.
>>>>>
>>>>> On 11.08.16 0:15, Philip Race wrote:
>>>>>> Equals was returning true because the full name is the same for
>>>>>> all members of the family. That in itself seems wrong .. no two
>>>>>> fonts should have the same name, but that will be addressed in
>>>>>> a follow-on fix.
>>>>>
>>>>> I assume the added code will be removed after follow-on fix?
>>>>
>>>> It does not have to be .. it is harmless and perhaps useful. I was
>>>> thinking of leaving it.
>>>>
>>>> -phil.
>>>>>
>>
>>

[prev in list] [next in list] [prev in thread] [next in thread]