[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: JDK-8163362-Reconsider reflection usage in java.awt.font.JavaAWTFontAccess
From:       Philip Race <philip.race () oracle ! com>
Date:       2016-08-23 4:28:55
Message-ID: 57BBD107.4010502 () oracle ! com
[Download RAW message or body]

This looks fine. I am just puzzled why reflection was used to begin with.
What am I missing ? Was this future proofing against new constants being 
added ?

-phil.

On 8/22/16, 7:40 PM, Rachna Goel wrote:
> Hi,
>
> Please review fix for JDK-8163362.
>
> https://bugs.openjdk.java.net/browse/JDK-8163362
>
> Webrev:http://cr.openjdk.java.net/~rgoel/JDK-8163362/webrev.01/
>
> This is a cleanup fix in which Reflection usage in JavaAWTFontAccessImpl
> class was removed.
>
> Thanks,
>
> Rachna

[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    This looks fine. I am just puzzled why reflection was used to begin
    with.<br>
    What am I missing ? Was this future proofing against new constants
    being added ?<br>
    <br>
    -phil.<br>
    <br>
    On 8/22/16, 7:40 PM, Rachna Goel wrote:
    <blockquote
      cite="mid:2ae64671-064b-ee3a-1b45-43c9f5776a18@oracle.com"
      type="cite">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <pre>Hi,

Please review fix for JDK-8163362.

<a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8163362">https://bugs.openjdk.java.net/browse/JDK-8163362</a>


Webrev: <a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Ergoel/JDK-8163362/webrev.01/">http://cr.openjdk.java.net/~rgoel/JDK-8163362/webrev.01/</a>


This is a cleanup fix in which Reflection usage in JavaAWTFontAccessImpl 
class was removed.

Thanks,

Rachna</pre>
    </blockquote>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic