[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163922: Print-to-file is disabled for SERVICE_FORMATTED docflavor
From: Philip Race <philip.race () oracle ! com>
Date: 2016-08-18 21:53:43
Message-ID: 57B62E67.3040801 () oracle ! com
[Download RAW message or body]
+1
-phil
On 8/18/16, 9:12 AM, Jayathirth D V wrote:
>
> Hi Prasanta,
>
> Changes are working fine.
>
> Thanks,
>
> Jay
>
> *From:*Prasanta Sadhukhan
> *Sent:* Thursday, August 18, 2016 5:30 PM
> *To:* Jayathirth D V; Philip Race; 2d-dev
> *Subject:* Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163922: Print-to-file is
> disabled for SERVICE_FORMATTED docflavor in linux
>
> Ok. I have extended the testcase to check both the non
> SERVICE_FORMATTED and SERVICE_FORMATTED cases by showing 2 print dialogs.
> Please have a look.
> http://cr.openjdk.java.net/~psadhukhan/8163922/webrev.01/
> <http://cr.openjdk.java.net/%7Epsadhukhan/8163922/webrev.01/>
>
> Regards
> Prasanta
>
> On 8/18/2016 4:37 PM, Jayathirth D V wrote:
>
> Hi Prasanta,
>
> Can you please verify whether we have any test case already
> present which actually checks this basic behavior of visible
> Print-to-File option enabled in SERVICE_FORMATTED DocFlavor.
>
> If not, we need to add test case which checks this behavior
> specifically, so that it can be part of regression test for the
> code change made in ServiceDialog.java.
>
> Thanks,
>
> Jay
>
> *From:*Prasanta Sadhukhan
> *Sent:* Friday, August 12, 2016 10:52 AM
> *To:* Philip Race; 2d-dev
> *Subject:* [OpenJDK 2D-Dev] [9] RFR JDK-8163922: Print-to-file is
> disabled for SERVICE_FORMATTED docflavor in linux
>
> Hi All,
>
> Please review a fix for an issue where it is seen that
> Print-to-File option is disabled even for SERVICE_FORMATTED
> DocFlavor after JDK-5049012
> <https://bugs.openjdk.java.net/browse/JDK-5049012> fix.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8163922
> webrev: http://cr.openjdk.java.net/~psadhukhan/8163922/webrev.00/
> <http://cr.openjdk.java.net/%7Epsadhukhan/8163922/webrev.00/>
>
> We need to enabled dstSupported even if the destination is not
> specified for SERVICE_FORMATTED DocFlavor.
>
> Regards
> Prasanta
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
+1<br>
<br>
-phil<br>
<br>
On 8/18/16, 9:12 AM, Jayathirth D V wrote:
<blockquote cite="mid:f56ade0c-b5a3-4296-81d5-e55e785ec473@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi
Prasanta,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> \
</o:p></span></p> <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Changes
are working fine.<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> \
</o:p></span></p> <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Jay<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> \
</o:p></span></p> <div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
Prasanta Sadhukhan <br>
<b>Sent:</b> Thursday, August 18, 2016 5:30 PM<br>
<b>To:</b> Jayathirth D V; Philip Race; 2d-dev<br>
<b>Subject:</b> Re: [OpenJDK 2D-Dev] [9] RFR
JDK-8163922: Print-to-file is disabled for
SERVICE_FORMATTED docflavor in linux<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Ok. I have extended the testcase to check
both the non SERVICE_FORMATTED and SERVICE_FORMATTED cases by
showing 2 print dialogs.<br>
Please have a look.<br>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Epsadhukhan/8163922/webrev.01/">http://cr.openjdk.java.net/~psadhukhan/8163922/webrev.01/</a><br>
<br>
Regards<br>
Prasanta<o:p></o:p></p>
<div>
<p class="MsoNormal">On 8/18/2016 4:37 PM, Jayathirth D V
wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi
Prasanta,</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> \
</span><o:p></o:p></p> <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Can
you please verify whether we have any test case already
present which actually checks this basic behavior of
visible Print-to-File option enabled in SERVICE_FORMATTED
DocFlavor.</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> \
</span><o:p></o:p></p> <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">If
not, we need to add test case which checks this behavior
specifically, so that it can be part of regression test
for the code change made in ServiceDialog.java.</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> \
</span><o:p></o:p></p> <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks,</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Jay</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> \
</span><o:p></o:p></p> <div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
Prasanta Sadhukhan <br>
<b>Sent:</b> Friday, August 12, 2016 10:52 AM<br>
<b>To:</b> Philip Race; 2d-dev<br>
<b>Subject:</b> [OpenJDK 2D-Dev] [9] RFR JDK-8163922:
Print-to-file is disabled for SERVICE_FORMATTED
docflavor in linux</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Hi All,<br>
<br>
Please review a fix for an issue where it is seen that
Print-to-File option is disabled even for SERVICE_FORMATTED
DocFlavor after <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-5049012"
title="PrintToFile option is not disabled for flavors
that
do not
support destination"><s>JDK-5049012</s></a>
fix.<br>
Bug: <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8163922">https://bugs.openjdk.java.net/browse/JDK-8163922</a><br>
webrev: <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Epsadhukhan/8163922/webrev.00/">http://cr.openjdk.java.net/~psadhukhan/8163922/webrev.00/</a><br>
<br>
We need to enabled dstSupported even if the destination is
not specified for SERVICE_FORMATTED DocFlavor.<br>
<br>
Regards<br>
Prasanta<o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</blockquote>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic