[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9] RFR JDK-5080098: Page Range must be disabled on the common print dlg for No
From:       Prasanta Sadhukhan <prasanta.sadhukhan () oracle ! com>
Date:       2016-07-29 5:40:27
Message-ID: 579AE97B.6090403 () oracle ! com
[Download RAW message or body]

Yes, right. Please find the modified webrev:
http://cr.openjdk.java.net/~psadhukhan/5080098/webrev.02/

Regards
Prasanta
On 7/28/2016 7:10 PM, Philip Race wrote:
> This can now be written more succinctly (and clearly) as :
> prPgRngSupported =psCurrent.isAttributeValueSupported(prAll, 
> docFlavor, asCurrent);
>
> -phil.
>
> On 7/28/16, 3:27 AM, Prasanta Sadhukhan wrote:
>> Trying to be extra cautious. Please find modified webrev:
>> http://cr.openjdk.java.net/~psadhukhan/5080098/webrev.01/
>>
>> Regards
>> Prasanta
>> On 7/27/2016 9:55 PM, Phil Race wrote:
>>> prAll is final and initalised. So why are you testing !=null ?
>>>
>>> -phil.
>>>
>>> On 07/05/2016 02:08 AM, Prasanta Sadhukhan wrote:
>>>> Hi All,
>>>>
>>>> Please review a fix for an issue where it is seen "Page range 
>>>> (From/To) " field is not disabled for flavors such as postscript, 
>>>> image flavors.
>>>> PageRanges attribute is supported only for Service Formatted 
>>>> flavors such as Pageable and Printable and so for
>>>> other flavors such as postscript, image flavors page ranges fields 
>>>> must be disabled on the print dialog so as not to allow the user to 
>>>> select the same
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-5080098
>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/5080098/webrev.00/
>>>>
>>>> Proposed fix is to check for attribute against the specified doc 
>>>> flavor
>>>> and not against attribute category to decide whether to enable / 
>>>> disable it.
>>>>
>>>> Regards
>>>> Prasanta
>>>
>>


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Yes, right. Please find the modified webrev:<br>
    <a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~psadhukhan/5080098/webrev.02/">http://cr.openjdk.java.net/~psadhukhan/5080098/webrev.02/</a><br>
  <br>
    Regards<br>
    Prasanta<br>
    <div class="moz-cite-prefix">On 7/28/2016 7:10 PM, Philip Race
      wrote:<br>
    </div>
    <blockquote cite="mid:579A0B4A.1060400@oracle.com" type="cite">
      <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
      This can now be written more succinctly (and clearly) as :<br>
      <meta http-equiv="content-type" content="text/html; charset=utf-8">
      <pre><span class="new">prPgRngSupported =</span><span class="new"> \
psCurrent.isAttributeValueSupported(prAll, docFlavor, </span><span \
class="new">asCurrent);</span><span class="new"></span></pre>  <br>
      -phil.<br>
      <br>
      On 7/28/16, 3:27 AM, Prasanta Sadhukhan wrote:
      <blockquote cite="mid:5799DDF7.30900@oracle.com" type="cite">Trying

        to be extra cautious. Please find modified webrev: <br>
        <a moz-do-not-send="true" class="moz-txt-link-freetext"
          href="http://cr.openjdk.java.net/%7Epsadhukhan/5080098/webrev.01/">http://cr.openjdk.java.net/~psadhukhan/5080098/webrev.01/</a>
  <br>
        <br>
        Regards <br>
        Prasanta <br>
        On 7/27/2016 9:55 PM, Phil Race wrote: <br>
        <blockquote type="cite">prAll is final and initalised. So why
          are you testing !=null ? <br>
          <br>
          -phil. <br>
          <br>
          On 07/05/2016 02:08 AM, Prasanta Sadhukhan wrote: <br>
          <blockquote type="cite">Hi All, <br>
            <br>
            Please review a fix for an issue where it is seen "Page
            range (From/To) " field is not disabled for flavors such as
            postscript, image flavors. <br>
            PageRanges attribute is supported only for Service Formatted
            flavors such as Pageable and Printable and so for <br>
            other flavors such as postscript, image flavors page ranges
            fields must be disabled on the print dialog so as not to
            allow the user to select the same <br>
            <br>
            Bug: <a moz-do-not-send="true"
              class="moz-txt-link-freetext"
              href="https://bugs.openjdk.java.net/browse/JDK-5080098">https://bugs.openjdk.java.net/browse/JDK-5080098</a>
  <br>
            webrev: <a moz-do-not-send="true"
              class="moz-txt-link-freetext"
              href="http://cr.openjdk.java.net/%7Epsadhukhan/5080098/webrev.00/">http://cr.openjdk.java.net/~psadhukhan/5080098/webrev.00/</a>
  <br>
            <br>
            Proposed fix is to check for attribute against the specified
            doc flavor <br>
            and not against attribute category to decide whether to
            enable / disable it. <br>
            <br>
            Regards <br>
            Prasanta <br>
          </blockquote>
          <br>
        </blockquote>
        <br>
      </blockquote>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic