'Re: [OpenJDK 2D-Dev] [9] RFR JDK-6591280: getting IPP connection causes disabling jar caches'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9] RFR JDK-6591280: getting IPP connection causes disabling jar caches
From:       Phil Race <philip.race () oracle ! com>
Date:       2016-07-25 20:59:23
Message-ID: 57967DAB.9010700 () oracle ! com
[Download RAW message or body]

+1

FWIW this being an instance method hides what it does.
It seems like it should have been static but as discussed here it is too 
late for that :-
https://bugs.openjdk.java.net/browse/JDK-4851466

-phil.

On 07/25/2016 02:57 AM, Prasanta Sadhukhan wrote:
> Hi All,
>
> Please review a fix for jdk9 where it is seen that we are 
> unnecessarily disabling jar caching for entire JVM execution
> when a IPPConnection is established, which is wrong.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-6591280
> webrev: http://cr.openjdk.java.net/~psadhukhan/6591280/webrev.00/
>
> When IPPService.getIPPConnection(URL url) is called, we call 
> connection.setDefaultUsesCaches(false) [in addition to 
> connection.setUseCaches(false);]
> where "connection" is instance of HttpUrlConnection.
> Calling this setDefaultUsesCaches(false) will result in disabling 
> |URLConnection|'s |useCaches| flag and as spec states "This flag 
> applies to the next, and all following URLConnections that are created"
> so jar caching will be disabled for subsequent URLConnections too.
>
> Proposed fix is to remove this setting of disabling jvm-wide jar caching.
>
> Regards
> Prasanta
>


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">+1<br>
      <br>
      FWIW this being an instance method hides what it does.<br>
      It seems like it should have been static but as discussed here it
      is too late for that :-<br>
      <a class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-4851466">https://bugs.openjdk.java.net/browse/JDK-4851466</a><br>
  <br>
      -phil.<br>
      <br>
      On 07/25/2016 02:57 AM, Prasanta Sadhukhan wrote:<br>
    </div>
    <blockquote cite="mid:5795E298.8040306@oracle.com" type="cite">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      Hi All,<br>
      <br>
      Please review a fix for jdk9 where it is seen that we are
      unnecessarily disabling jar caching for entire JVM execution <br>
      when a IPPConnection is established, which is wrong.<br>
      <br>
      Bug: <a moz-do-not-send="true" class="moz-txt-link-freetext"
        href="https://bugs.openjdk.java.net/browse/JDK-6591280">https://bugs.openjdk.java.net/browse/JDK-6591280</a><br>
  webrev: <a moz-do-not-send="true" class="moz-txt-link-freetext"
        href="http://cr.openjdk.java.net/%7Epsadhukhan/6591280/webrev.00/">http://cr.openjdk.java.net/~psadhukhan/6591280/webrev.00/</a><br>
  <br>
      When IPPService.getIPPConnection(URL url) is called, we call
      connection.setDefaultUsesCaches(false) [in addition to
      connection.setUseCaches(false);] <br>
      where "connection" is instance of HttpUrlConnection.<br>
      Calling this setDefaultUsesCaches(false) will result in disabling
      <code>URLConnection</code>'s <code>useCaches</code> flag and as
      spec states "This flag applies to the next, and all following
      URLConnections that are created"<br>
      so jar caching will be disabled for subsequent URLConnections too.<br>
      <br>
      Proposed fix is to remove this setting of disabling jvm-wide jar
      caching.<br>
      <br>
      Regards<br>
      Prasanta<br>
      <br>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic