[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-4882305: StreamPrintServ.getSupportedAttributeValues returns null f
From: Ajit Ghaisas <ajit.ghaisas () oracle ! com>
Date: 2016-07-22 11:09:23
Message-ID: 257792cb-61b2-403b-997d-468e35dfda47 () default
[Download RAW message or body]
Hi Prasanta,
1. The test contains commented code – that needs to be removed
2. The test only tests for image/jpeg docFlavor – what about image/gif \
and image/png docflavors testing?
3. The year in banner at the top of PSStreamPrintService.java can be \
updated
Regards,
Ajit
From: Philip Race
Sent: Wednesday, July 20, 2016 8:44 PM
To: Prasanta Sadhukhan
Cc: 2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-4882305: \
StreamPrintServ.getSupportedAttributeValues returns null for Orientation attr
+1
-phil.
On 7/14/16, 2:09 AM, Prasanta Sadhukhan wrote:
Hi All,
Please review a fix for an issue where it is seen that
even though StreamPrintService returns OrientationRequested category as supported, \
when actually querying the supported attribute value with respect to the supported \
DocFlavors, null values are returned for the Orientation attributes when the \
DocFlavor is not either Pageable or Printable (SERVICE_FORMATTED) BUT we can print a \
jpeg iamge using StreamPrintService in LANDSCAPE mode and it worked fine so \
StreamPrintService should not return the supported values as null for supported \
DocFlavor.
Bug: https://bugs.openjdk.java.net/browse/JDK-4882305
webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epsadhukhan/4882305/webrev.00/"http://cr.openjdk.java.net/~psadhukhan/4882305/webrev.00/
Proposed fix is to add the image/jpeg, image/gif, image/png docflavor in addition to \
Pageable/Printable for Orientation attribute.
Regards
Prasanta
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:1901357286;
mso-list-type:hybrid;
mso-list-template-ids:-804455948 67698703 67698713 67698715 67698703 67698713 \
67698715 67698703 67698713 67698715;} @list l0:level1
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level2
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level3
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level4
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level5
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level6
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level7
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level8
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level9
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-US link=blue \
vlink=purple><div class=WordSection1><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Hi \
Prasanta,<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoListParagraph style='text-indent:-.25in;mso-list:l0 level1 lfo1'><![if \
!supportLists]><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><span \
style='mso-list:Ignore'>1.<span style='font:7.0pt "Times New \
Roman"'> </span></span></span><![endif]><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>The test \
contains commented code – that needs to be removed<o:p></o:p></span></p><p \
class=MsoListParagraph style='text-indent:-.25in;mso-list:l0 level1 lfo1'><![if \
!supportLists]><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><span \
style='mso-list:Ignore'>2.<span style='font:7.0pt "Times New \
Roman"'> </span></span></span><![endif]><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>The test \
only tests for image/jpeg docFlavor – what about image/gif and image/png docflavors \
testing?<o:p></o:p></span></p><p class=MsoListParagraph \
style='text-indent:-.25in;mso-list:l0 level1 lfo1'><![if !supportLists]><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><span \
style='mso-list:Ignore'>3.<span style='font:7.0pt "Times New \
Roman"'> </span></span></span><![endif]><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>The year in \
banner at the top of PSStreamPrintService.java can be updated<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Regards,<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Ajit<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><div><div \
style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p \
class=MsoNormal><b><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:windowtext'>From:</span></b><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:windowtext'> Philip \
Race <br><b>Sent:</b> Wednesday, July 20, 2016 8:44 PM<br><b>To:</b> Prasanta \
Sadhukhan<br><b>Cc:</b> 2d-dev<br><b>Subject:</b> Re: [OpenJDK 2D-Dev] [9] RFR \
JDK-4882305: StreamPrintServ.getSupportedAttributeValues returns null for Orientation \
attr<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal>+1<br><br>-phil.<br><br>On 7/14/16, 2:09 AM, Prasanta Sadhukhan \
wrote: <o:p></o:p></p><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p \
class=MsoNormal>Hi All,<br><br>Please review a fix for an issue where it is seen that \
<br>even though StreamPrintService returns OrientationRequested category as \
supported, when actually querying the supported attribute value with respect to the \
supported DocFlavors, <br><b>null</b> values are returned for the Orientation \
attributes when the DocFlavor is not either Pageable or Printable \
(SERVICE_FORMATTED)<br><b>BUT</b> we can print a jpeg iamge using StreamPrintService \
in LANDSCAPE mode and it worked fine so StreamPrintService should not return the \
supported values as null for supported DocFlavor.<br><br>Bug: <a \
href="https://bugs.openjdk.java.net/browse/JDK-4882305">https://bugs.openjdk.java.net/browse/JDK-4882305</a><br>webrev: \
<a href="http://cr.openjdk.java.net/%7Epsadhukhan/4882305/webrev.00/">http://cr.openjdk.java.net/~psadhukhan/4882305/webrev.00/</a><br><br>Proposed \
fix is to add the image/jpeg, image/gif, image/png docflavor in addition to \
Pageable/Printable for Orientation \
attribute.<br><br>Regards<br>Prasanta<o:p></o:p></p></blockquote></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic