[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR (urgent) 8162097: [PIT] A series of closed tests about SunFontManager throw
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2016-07-21 21:55:31
Message-ID: 534e34bc-0700-ac3d-7052-ded733862ded () oracle ! com
[Download RAW message or body]

+1

On 21.07.16 20:54, Brian Burkhalter wrote:
> This looks fine as far as I can see.
>
> Brian
>
> On Jul 21, 2016, at 9:57 AM, Phil Race <philip.race@oracle.com> wrote:
>
>> http://cr.openjdk.java.net/~prr/8162097/
>>
>> I have an urgent RFR which is blocking PIT.
>>
>> The fix  : https://bugs.openjdk.java.net/browse/JDK-8152971 to eliminate some JNI warnings.
>>
>> is prematurely deleting a local ref which is used in a callback function.
>> As as result we get many NPEs in Java code.
>> The fix is to move the (normal case) delete to after we've done with the callback.
>>
>> The tests which failed before this fix now pass.
>> Also the JNI check test is not seeing "new" issues .. there are already JNI warnings
>> that it finds in other code.
>>
>> -phil.
>


-- 
Best regards, Sergey.
[prev in list] [next in list] [prev in thread] [next in thread]