[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8160693: ScriptRunData.java uses bitwise AND instead of logical AND
From:       Jim Graham <james.graham () oracle ! com>
Date:       2016-06-30 23:51:16
Message-ID: 5775B074.5000906 () oracle ! com
[Download RAW message or body]

I don't see the need for the extra parentheses in this particular case, 
but the change/fix looks good...

			...jim

On 06/30/2016 03:25 PM, Phil Race wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8160693
>
> Fix :-
>   hg diff src/java.desktop/share/classes/sun/font/ScriptRunData.java
> diff --git a/src/java.desktop/share/classes/sun/font/ScriptRunData.java
> b/src/java.desktop/share/classes/sun/font/ScriptRunData.java
> --- a/src/java.desktop/share/classes/sun/font/ScriptRunData.java
> +++ b/src/java.desktop/share/classes/sun/font/ScriptRunData.java
> @@ -44,7 +44,7 @@
>           if (cp >= data[cache] && cp < data[cache+2]) {
>               return data[cache+1];
>           }
> -        if (cp >= CHAR_START & cp < CHAR_LIMIT) {
> +        if ((cp >= CHAR_START) && (cp < CHAR_LIMIT)) {
>               int probe = dataPower;
>               int index = 0;
>
>
> -phil.
>
[prev in list] [next in list] [prev in thread] [next in thread]