[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] (Review request) JDK-8152971: -Xcheck:jni warning
From: prasanta sadhukhan <prasanta.sadhukhan () oracle ! com>
Date: 2016-06-16 6:56:51
Message-ID: 99726247-e65b-eaef-9811-155cd3e841f9 () oracle ! com
[Download RAW message or body]
Please mention for which jdk release you are asking this review for
like [9] for jdk9 !!
awt_Component.cpp: Should we continue if there is any exception? You are
just clearing the exception here, should we also not return as the "obj"
values are going to be used later on which again will show up other
problems!!
fontpath.c.
177, 286 this return 1 is not needed
I guess you need to also put noreg-sqe or so in JBS label as it does not
have testcase and you are using existing JNICheck script.
Regards
Prasanta
On 6/15/2016 10:47 PM, Prahalad Kumar Narayanan wrote:
> Hello Everyone on Java2D group
>
> Good day to you.
>
> Please find herewith, webrev with changes to fix the following issue:
> Bug ID / Title : JDK-8152971 -Xcheck:jni - WARNING in native method
> Bug Link : https://bugs.openjdk.java.net/browse/JDK-8152971
>
> Description on Bug :
> . Submitter has provided a test code with the bug.
> . When the test code is run (with -Xcheck:jni in JVM options), JNI warnings are \
> thrown.
> . The warnings mention that JNI functions invoke Java methods without checking for \
> exceptions.
> Description on Changes :
> . The bug did not appear in Jdk 8 b132 or earlier but is reproducible with 8u91 and \
> 9 versions. I believe, strict check for conformance has been added recently in JVM \
> that has caused this issue.
> . In the proposed fix, I 've added JNIEnv->ExceptionCheck and ExceptionClear \
> functions at required places.
> Webrev Link:
> http://cr.openjdk.java.net/~pnarayanan/8152971/webrev.00/
>
> Kindly review the changes at your available time and provide your feedback.
>
> Thanks for your time in review
> Have a good day
>
> Prahalad N
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Please mention for which jdk release you are asking this review
for like [9] for jdk9 !!<br>
</p>
<p>awt_Component.cpp: Should we continue if there is any exception?
You are just clearing the exception here, should we also not
return as the "obj" values are going to be used later on which
again will show up other problems!!<br>
</p>
fontpath.c.<span class="new"><br>
177, 286</span><span class="new"> this return 1 is not needed</span><br>
<br>
I guess you need to also put noreg-sqe or so in JBS label as it does
not have testcase and you are using existing JNICheck script.<br>
<br>
Regards<br>
Prasanta<br>
<span class="new"><br>
</span>
<div class="moz-cite-prefix">On 6/15/2016 10:47 PM, Prahalad Kumar
Narayanan wrote:<br>
</div>
<blockquote cite="mid:d4b5f0d3-6ba5-4ce2-93ea-e1843214aaee@default"
type="cite">
<pre wrap="">Hello Everyone on Java2D group
Good day to you.
Please find herewith, webrev with changes to fix the following issue:
Bug ID / Title : JDK-8152971 -Xcheck:jni - WARNING in native method
Bug Link : <a class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8152971">https://bugs.openjdk.java.net/browse/JDK-8152971</a>
Description on Bug :
. Submitter has provided a test code with the bug.
. When the test code is run (with -Xcheck:jni in JVM options), JNI warnings are \
thrown.
. The warnings mention that JNI functions invoke Java methods without checking \
for exceptions.
Description on Changes :
. The bug did not appear in Jdk 8 b132 or earlier but is reproducible with 8u91 \
and 9 versions.
I believe, strict check for conformance has been added recently in JVM \
that has caused this issue.
. In the proposed fix, I 've added JNIEnv->ExceptionCheck and ExceptionClear \
functions at required places.
Webrev Link:
<a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~pnarayanan/8152971/webrev.00/">http://cr.openjdk.java.net/~pnarayanan/8152971/webrev.00/</a>
Kindly review the changes at your available time and provide your feedback.
Thanks for your time in review
Have a good day
Prahalad N
</pre>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic