[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9] RFR JDK-8158520: [TEST_BUG] java/awt/PrintJob/PrinterException.java fails o
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2016-06-06 14:49:13
Message-ID: 1708025e-f5ea-ccae-2935-4ba012c46f8e () oracle ! com
[Download RAW message or body]

Looks fine.

On 06.06.16 10:02, prasanta sadhukhan wrote:
> Hi Sergey,
>
> Please find the modified webrev with ESC. The previous bug can also be
> reproduced with this without the 7161283 fix.
> http://cr.openjdk.java.net/~psadhukhan/8158520/webrev.01/
>
> Regards
> Prasanta
> On 6/3/2016 7:46 PM, prasanta sadhukhan wrote:
>>
>> Ok. we can pass VK_ESCAPE instead of VK_ENTER and it works ok.
>>
>> Regards
>> Prasanta
>> On 6/3/2016 7:37 PM, prasanta sadhukhan wrote:
>>> No, we do not really need to print anything but we need to show the
>>> printdialog to reproduce the previous bug. But to avoid human
>>> interaction ,we need to close the dialog so that jtreg should not
>>> fail in timeout.
>>>
>>> I am not sure how to select "Cancel" in the print dialog
>>> automatically but Print or Cancel does not change the behaviour, so
>>> we are just pressing "Enter". In windows and linux, the "focus" is on
>>> print and in osx, the "focus" is on cancel.
>>>
>>> Regards
>>> Prasanta
>>> On 6/3/2016 5:31 PM, Sergey Bylokhov wrote:
>>>> Do we really need try to print something or cancel(ESC) will be
>>>> enough to reproduce the previous bug?
>>>>
>>>> On 03.06.16 14:46, prasanta sadhukhan wrote:
>>>>> Please review a test bug which was added for bug 7161283.
>>>>> Toolkit.getPrintJob() threw a NPE if no printer was available.
>>>>>
>>>>> Although the testcase was working ok in failure case by throwing
>>>>> NPE, in
>>>>> pass case it was waiting for manual intervention causing jtreg to fail
>>>>> on timeout.
>>>>>
>>>>> Made the testcase automated to use Robot to press Enter as the
>>>>> focus in
>>>>> the dialog is in the "Print" button. Using Robot to press Enter closes
>>>>> the dialog without the need for manual intervention.
>>>>>
>>>>> Tested on windows, linux and mac.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8158520
>>>>>
>>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8158520/webrev.00/
>>>>>
>>>>>
>>>>> Regards
>>>>>
>>>>> Prasanta
>>>>>
>>>>
>>>>
>>>
>>
>


-- 
Best regards, Sergey.
[prev in list] [next in list] [prev in thread] [next in thread]