[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR 6212751: DOC: ServiceUI.printDialog() need to enhance the description f
From: Phil Race <philip.race () oracle ! com>
Date: 2016-05-31 18:34:55
Message-ID: 574DD94F.1090900 () oracle ! com
[Download RAW message or body]
Before I forget this one looks as if it may need a CCC - if it goes that
far.
Remember to revisit that before it is done.
Yet I am not sure I accept what is written in the bug report as being
the basis
for updating these docs.
The existing javadoc on ServiceUI appears consistent with what is
written here :
https://docs.oracle.com/javase/8/docs/api/java/awt/GraphicsConfiguration.html
The specified "GC" - best written out as "GraphicsConfiguration" in the
docs -
targets a specific physical monitor/screen regardless of whether the screens
are separate or there is one virtual screen spanning them.
The x/y are then relative to the origin of that monitor/screen.
>this value depicts the GC ofthe active window.
All references to "active window" fall flat if there is no such window
so I don't think you should (or can) bake such an assumption into the
javadoc.
Remember this dialog could be the *only* window that is ever displayed
by the app.
But even more importantly this is simply wrong.
I can specify *any* GC I want. Nothing should be forcing me to display it
only on the same screen as the active window - if there is one.
It might be what you usually want to do but that is a choice ..
If I was to speculate, I might say that the comments written in 6212751
were a result of confusion due to the issues described in 8138749 (and
its original report under 5109347).
-phil.
On 05/27/2016 04:54 AM, prasanta sadhukhan wrote:
>
> Hi All,
>
> Please review a doc fix for jdk9.
> Bug: https://bugs.openjdk.java.net/browse/JDK-6212751
> webrev: http://cr.openjdk.java.net/~psadhukhan/6212751/webrev.00/
>
> After JDK-8138749 <https://bugs.openjdk.java.net/browse/JDK-8138749>
> multimonitor support fix, the doc needs some change. It was also
> misleading in the first place as the bugdescription pointed out
> which is API doc for ServiceUI.printDialog() specifies that X,Y are
> location of the dialog in screen coordinates, but for multmonitor
> setup, it should be w.r.t to secondary screen
> because
> . If the sec monitor starts at 1025, 0 and If I specify 1025 as the X
> coordinate, the calculated X value would be 1025 + 1025 = 2050 which
> actually exceeds the bounds of virtual screen.
>
> Updated the documentation .
>
> Regards
> Prasanta
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Before I forget this one looks as if it
may need a CCC - if it goes that far.<br>
Remember to revisit that before it is done.<br>
<span class="changed"><br>
</span>Yet I am not sure I accept what is written in the bug
report as being the basis<br>
for updating these docs.<br>
<br>
The existing javadoc on ServiceUI appears consistent with what is
written here :<br>
<a class="moz-txt-link-freetext" \
href="https://docs.oracle.com/javase/8/docs/api/java/awt/GraphicsConfiguration.html">h \
ttps://docs.oracle.com/javase/8/docs/api/java/awt/GraphicsConfiguration.html</a><br> \
<br> The specified "GC" - best written out as "GraphicsConfiguration"
in the docs - <br>
targets a specific physical monitor/screen regardless of whether
the screens<br>
are separate or there is one virtual screen spanning them.<br>
The x/y are then relative to the origin of that monitor/screen.<br>
<br>
><span class="changed"> this value depicts the GC of</span><span
class="changed"> the active window.<br>
<br>
</span>
All references to "active window" fall flat if there is no such
window<br>
so I don't think you should (or can) bake such an assumption into
the javadoc.<br>
Remember this dialog could be the *only* window that is ever
displayed by the app.<br>
<br>
But even more importantly this is simply wrong.<br>
I can specify *any* GC I want. Nothing should be forcing me to
display it<br>
only on the same screen as the active window - if there is one.<br>
It might be what you usually want to do but that is a choice .. <span
class="changed"><br>
</span><br>
If I was to speculate, I might say that the comments written in
6212751<br>
were a result of confusion due to the issues described in 8138749
(and<br>
its original report under 5109347).<br>
<br>
-phil.<br>
<br>
On 05/27/2016 04:54 AM, prasanta sadhukhan wrote:<br>
</div>
<blockquote
cite="mid:52b96c89-0774-f473-a311-b9ea04448720@oracle.com"
type="cite">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<p>Hi All,</p>
Please review a doc fix for jdk9.<br>
Bug: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-6212751">https://bugs.openjdk.java.net/browse/JDK-6212751</a><br>
webrev: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Epsadhukhan/6212751/webrev.00/">http://cr.openjdk.java.net/~psadhukhan/6212751/webrev.00/</a><br>
<br>
After <a moz-do-not-send="true" class="issue-link"
data-issue-key="JDK-8138749"
href="https://bugs.openjdk.java.net/browse/JDK-8138749"
id="key-val" rel="4847829">JDK-8138749</a> multimonitor support
fix, the doc needs some change. It was also misleading in the
first place as the bugdescription pointed out<br>
which is API doc for ServiceUI.printDialog() specifies that X,Y
are location of the dialog in screen coordinates, but for
multmonitor setup, it should be w.r.t to secondary screen<br>
because<br>
. If the sec monitor starts at 1025, 0 and If I specify 1025 as
the X coordinate, the calculated X value would be 1025 + 1025 =
2050 which actually exceeds the bounds of virtual screen.<br>
<br>
Updated the documentation .<br>
<br>
Regards<br>
Prasanta<br>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic