[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: [OpenJDK 2D-Dev] RFR: 8149815: Misleading
From: Bluv Nallakaluva <bharath.nallakaluva () oracle ! com>
Date: 2016-05-19 18:06:44
Message-ID: 664fffef-1c56-4d91-a6a1-0014dfdfcea1 () default
[Download RAW message or body]
Hi Brian,
I think the change looks fine.
However I want confirm the reason for the check "type == TIFFTag.LONG" besides \
type == TIFFTag.TIFF_IFD_POINTER .
From this http://partners.adobe.com/public/developer/en/tiff/TIFFPM6.pdf. , it is \
clear that IFD /LONG type can be used for the tag "SubIFD". (this entry points to a \
Thumbnail IFD)
Here the IFD entry corresponding to this tag should have the node name "TIFFIFD" \
which makes sense.
So there might be other IFD entries that would have a tag whose type can be LONG and \
still they have the value as the address to the actual IFD just like the above \
"SubIFD"
And for these entries the node name being "TIFFIFD" is valid.
Can you confirm if my understanding is correct ?
Also I think I caught one more place where this instanceof is used in TIFFFieldNode,
The following excerpt from TIFFFieldNode constructor. I believe this one should also \
be fixed.
isIFD = field.getData() instanceof TIFFDirectory;
Thanks,
Bharath N
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 12 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:Consolas;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div \
class=WordSection1><p class=MsoNormal>Hi Brian,<o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>I think the change looks \
fine. <o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal>However I want confirm the reason for the check <b>“type \
== TIFFTag.LONG”</b> besides type == TIFFTag.TIFF_IFD_POINTER \
.<o:p></o:p></p><p class=MsoNormal>From this <a \
href="http://partners.adobe.com/public/developer/en/tiff/TIFFPM6.pdf">http://partners.adobe.com/public/developer/en/tiff/TIFFPM6.pdf</a>. \
, it is clear that IFD /LONG type can be used for the tag “SubIFD”. (this \
entry points to a Thumbnail IFD)<o:p></o:p></p><p class=MsoNormal>Here the IFD entry \
corresponding to this tag should have the node name “TIFFIFD” which makes \
sense.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>So \
there might be other IFD entries that would have a tag whose type can be LONG \
and still they have the value as the address to the actual IFD just like the above \
“SubIFD” <o:p></o:p></p><p class=MsoNormal>And for these entries the node \
name being “TIFFIFD” is valid.<o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Can you confirm if my \
understanding is correct ? <o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Also I think I caught one \
more place where this instanceof is used in TIFFFieldNode,<o:p></o:p></p><p \
class=MsoNormal>The following excerpt from TIFFFieldNode constructor. I believe this \
one should also be fixed.<o:p></o:p></p><p class=MsoNormal><span \
style='font-size:9.0pt;font-family:"Courier \
New";color:black;background:#FFE4FF'><o:p> </o:p></span></p><p class=MsoNormal \
style='background:white'><span style='font-size:9.0pt;font-family:"Courier \
New";color:black;background:#FFE4FF'>isIFD</span><span \
style='font-size:9.0pt;font-family:"Courier New";color:black'> = field.getData() \
</span><b><span style='font-size:9.0pt;font-family:"Courier \
New";color:navy'>instanceof </span></b><span \
style='font-size:9.0pt;font-family:"Courier \
New";color:black'>TIFFDirectory;<o:p></o:p></span></p><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal>Thanks,<o:p></o:p></p><p class=MsoNormal>Bharath N<o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal><o:p> </o:p></p></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic