[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] Review Request: JDK-6587251 Import declaration not used in sun.java2d.*
From: Phil Race <philip.race () oracle ! com>
Date: 2016-05-17 17:20:11
Message-ID: 573B52CB.3070200 () oracle ! com
[Download RAW message or body]
+1
-phil.
On 05/17/2016 03:38 AM, prasanta sadhukhan wrote:
> Looks good.
>
> Regards
> Prasanta
> On 5/17/2016 4:04 PM, Prem Balakrishnan wrote:
>>
>> Hi Prasanta,
>>
>> Thank you for the Review.
>>
>> Updated patch as per review comments.
>>
>> http://cr.openjdk.java.net/~pkbalakr/6587251/webrev.01/
>>
>> Regards,
>> Prem
>>
>> *From:*prasanta sadhukhan
>> *Sent:* Tuesday, May 17, 2016 3:33 PM
>> *To:* Prem Balakrishnan; Philip Race; 2d-dev@openjdk.java.net
>> *Subject:* Re: Review Request: JDK-6587251 Import declaration not
>> used in sun.java2d.*
>>
>> Hi Prem,
>>
>> Looks good to me.
>> Some files you have changed the copyright year, some files you have
>> not like
>> sun/java2d/pipe/OutlineTextRenderer.java, sun/java2d/pipe/LoopPipe.java
>> although I do not think it is necessary to change manually, but
>> please be consistent.
>>
>> Also, please put "noreg-cleanup" in the bug label.
>>
>> Regards
>> Prasanta
>>
>> On 5/17/2016 3:00 PM, Prem Balakrishnan wrote:
>>
>> Hi,
>>
>> Please review fix for JDK9,
>>
>> *Bug:*https://bugs.openjdk.java.net/browse/JDK-6587251
>>
>> *Webrev:*http://cr.openjdk.java.net/~pkbalakr/6587251/webrev.00/
>> <http://cr.openjdk.java.net/%7Epkbalakr/6587251/webrev.00/>
>>
>> Removed unused Import declaration in sun.java2d.*
>>
>> Regards,
>> Prem
>>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">+1<br>
<br>
-phil.<br>
<br>
On 05/17/2016 03:38 AM, prasanta sadhukhan wrote:<br>
</div>
<blockquote cite="mid:573AF494.3020004@oracle.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
Looks good.<br>
<br>
Regards<br>
Prasanta<br>
<div class="moz-cite-prefix">On 5/17/2016 4:04 PM, Prem
Balakrishnan wrote:<br>
</div>
<blockquote
cite="mid:d1542597-49ed-4e40-88aa-a7ee61b06297@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 12 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hi \
Prasanta,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thank you for
the Review.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Updated patch
as per review comments.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Epkbalakr/6587251/webrev.01/">http://cr.openjdk.java.net/~pkbalakr/6587251/webrev.01/</a>
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Regards,<br>
Prem<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">
prasanta sadhukhan <br>
<b>Sent:</b> Tuesday, May 17, 2016 3:33 PM<br>
<b>To:</b> Prem Balakrishnan; Philip Race; <a
moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:2d-dev@openjdk.java.net">2d-dev@openjdk.java.net</a><br>
<b>Subject:</b> Re: Review Request: JDK-6587251 Import
declaration not used in sun.java2d.*<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi Prem,<br>
<br>
Looks good to me.<br>
Some files you have changed the copyright year, some files
you have not like<br>
sun/java2d/pipe/OutlineTextRenderer.java,
sun/java2d/pipe/LoopPipe.java <br>
although I do not think it is necessary to change manually,
but please be consistent.<br>
<br>
Also, please put "noreg-cleanup" in the bug label.<br>
<br>
Regards<br>
Prasanta<o:p></o:p></p>
<div>
<p class="MsoNormal">On 5/17/2016 3:00 PM, Prem Balakrishnan
wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span
lang="EN-IN">Please review fix for JDK9,</span><o:p></o:p></p>
<p class="MsoNormal"><b><span style="color:#1F497D"
lang="EN-IN">Bug:</span></b><span lang="EN-IN"> </span><span
style="color:#1F497D" lang="EN-IN"><a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-6587251">https://bugs.openjdk.java.net/browse/JDK-6587251</a>
</span><o:p></o:p></p>
<p class="MsoNormal"><b><span style="color:#1F497D"
lang="EN-IN">Webrev:</span></b><span
style="color:#1F497D" lang="EN-IN"> </span><span
style="color:#1F497D"><a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Epkbalakr/6587251/webrev.00/">http://cr.openjdk.java.net/~pkbalakr/6587251/webrev.00/</a>
</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal">Removed unused Import declaration in
sun.java2d.*<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Regards,<br>
Prem<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New
Roman","serif""><o:p> </o:p></span></p>
</div>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic