[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: [OpenJDK 2D-Dev] RFR: 8156580: Make TIFFTagSet subclasses final
From: Brian Burkhalter <brian.burkhalter () oracle ! com>
Date: 2016-05-17 0:38:43
Message-ID: 76E5E13F-9AD7-42FD-8956-21461251EC1C () oracle ! com
[Download RAW message or body]
Please review at your convenience.
Issue: https://bugs.openjdk.java.net/browse/JDK-8156580
Diff: [1]
Aside from the obvious ‘final’ changes there is a minor verbiage typo correction in \
the TIFFTagSet class javadoc.
Thanks,
Brian
[1] diff
--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/BaselineTIFFTagSet.java
+++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/BaselineTIFFTagSet.java
@@ -58,7 +58,7 @@
-public class BaselineTIFFTagSet extends TIFFTagSet {
+public final class BaselineTIFFTagSet extends TIFFTagSet {
--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifGPSTagSet.java
+++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifGPSTagSet.java
@@ -38,7 +38,7 @@
-public class ExifGPSTagSet extends TIFFTagSet {
+public final class ExifGPSTagSet extends TIFFTagSet {
--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifInteroperabilityTagSet.java
+++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifInteroperabilityTagSet.java
-public class ExifInteroperabilityTagSet extends TIFFTagSet {
+public final class ExifInteroperabilityTagSet extends TIFFTagSet {
--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifParentTIFFTagSet.java
+++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifParentTIFFTagSet.java
-public class ExifParentTIFFTagSet extends TIFFTagSet {
+public final class ExifParentTIFFTagSet extends TIFFTagSet {
--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifTIFFTagSet.java
+++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifTIFFTagSet.java
@@ -41,7 +41,7 @@
-public class ExifTIFFTagSet extends TIFFTagSet {
+public final class ExifTIFFTagSet extends TIFFTagSet {
--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/FaxTIFFTagSet.java
+++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/FaxTIFFTagSet.java
-public class FaxTIFFTagSet extends TIFFTagSet {
+public final class FaxTIFFTagSet extends TIFFTagSet {
--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/GeoTIFFTagSet.java
+++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/GeoTIFFTagSet.java
-public class GeoTIFFTagSet extends TIFFTagSet {
+public final class GeoTIFFTagSet extends TIFFTagSet {
/tiff/TIFFTagSet.java \
b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFTagSet.java
--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFTagSet.java
+++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFTagSet.java
@@ -34,14 +34,13 @@
/**
- * A class representing a set of TIFF tags. Each tag in the set must
- * have a unique number (this is a limitation of the TIFF
- * specification itself).
+ * A class representing a set of TIFF tags. Each tag in the set must have
+ * a unique number (this is a limitation of the TIFF specification itself).
*
* <p> This class and its subclasses are responsible for mapping
* between raw tag numbers and {@code TIFFTag} objects, which
* contain additional information about each tag, such as the tag's
- * name, legal data types, and mnemonic names for some or all of ts
+ * name, legal data types, and mnemonic names for some or all of its
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html \
charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; -webkit-line-break: after-white-space;">Please review at your \
convenience.<div><br></div><div>Issue:<span class="Apple-tab-span" \
style="white-space:pre"> </span><a \
href="https://bugs.openjdk.java.net/browse/JDK-8156580">https://bugs.openjdk.java.net/browse/JDK-8156580</a></div><div>Diff:<span \
class="Apple-tab-span" \
style="white-space:pre"> </span>[1]</div><div><br></div><div>Aside from the obvious \
‘final’ changes there is a minor verbiage typo correction in the TIFFTagSet class \
javadoc.</div><div><br></div><div>Thanks,</div><div><br></div><div>Brian</div><div><br></div><div>[1] \
diff</div><div><br></div><div><tt>--- \
a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/BaselineTIFFTagSet.java<br>+++ \
b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/BaselineTIFFTagSet.java<br>@@ \
-58,7 +58,7 @@<br> <br>-public class BaselineTIFFTagSet extends TIFFTagSet \
{<br>+public final class BaselineTIFFTagSet extends TIFFTagSet \
{<br> <br> <br>--- \
a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifGPSTagSet.java<br>+++ \
b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifGPSTagSet.java<br>@@ \
-38,7 +38,7 @@<br>-public class ExifGPSTagSet extends TIFFTagSet {<br>+public final \
class ExifGPSTagSet extends TIFFTagSet {<br> <br> <br>--- \
a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifInteroperabilityTagSet.java<br>+++ \
b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifInteroperabilityTagSet.java<br>-public \
class ExifInteroperabilityTagSet extends TIFFTagSet {<br>+public final class \
ExifInteroperabilityTagSet extends TIFFTagSet {<br> <br> <br>--- \
a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifParentTIFFTagSet.java<br>+++ \
b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifParentTIFFTagSet.java<br>-public \
class ExifParentTIFFTagSet extends TIFFTagSet {<br>+public final class \
ExifParentTIFFTagSet extends TIFFTagSet {<br> <br> <br>--- \
a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifTIFFTagSet.java<br>+++ \
b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifTIFFTagSet.java<br>@@ \
-41,7 +41,7 @@<br>-public class ExifTIFFTagSet extends TIFFTagSet {<br>+public final \
class ExifTIFFTagSet extends TIFFTagSet {<br> <br> <br>--- \
a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/FaxTIFFTagSet.java<br>+++ \
b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/FaxTIFFTagSet.java<br>-public \
class FaxTIFFTagSet extends TIFFTagSet {<br>+public final class FaxTIFFTagSet extends \
TIFFTagSet {<br> <br> <br>--- \
a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/GeoTIFFTagSet.java<br>+++ \
b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/GeoTIFFTagSet.java<br>-public \
class GeoTIFFTagSet extends TIFFTagSet {<br>+public final class GeoTIFFTagSet extends \
TIFFTagSet {<br> <br> <br>/tiff/TIFFTagSet.java \
b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFTagSet.java<br>--- \
a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFTagSet.java<br>+++ \
b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFTagSet.java<br>@@ \
-34,14 +34,13 @@<br> <br> /**<br>- * A class representing a set of TIFF \
tags. Each tag in the set must<br>- * have a unique number (this is a \
limitation of the TIFF<br>- * specification itself).<br>+ * A class representing a \
set of TIFF tags. Each tag in the set must have<br>+ * a unique number (this is \
a limitation of the TIFF specification itself).<br> *<br> * \
<p> This class and its subclasses are responsible for mapping<br> * \
between raw tag numbers and {@code TIFFTag} objects, which<br> * contain \
additional information about each tag, such as the tag's<br>- * name, legal data \
types, and mnemonic names for some or all of ts<br>+ * name, legal data types, and \
mnemonic names for some or all of its</tt></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic