[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8156459: SimpleCMYKColorSpace serialVersionUID is inappropriate
From:       Phil Race <philip.race () oracle ! com>
Date:       2016-05-06 19:15:05
Message-ID: 572CED39.8020504 () oracle ! com
[Download RAW message or body]

+1

-phil.

On 05/06/2016 11:57 AM, Brian Burkhalter wrote:
> Please review at your convenience.
>
> Issue:https://bugs.openjdk.java.net/browse/JDK-8156459
> Diff:[1]
>
> Summary: Replace the current value of serialVersionUID with one 
> created by the ‘serialver’ command.
>
> Thanks,
>
> Brian
>
> [1] hg diff:
>
> --- 
> a/src/java.desktop/share/classes/com/sun/imageio/plugins/common/SimpleCMYKColorSpace.java
> +++ 
> b/src/java.desktop/share/classes/com/sun/imageio/plugins/common/SimpleCMYKColorSpace.java
> @@ -31,7 +31,7 @@
>   * color space.
>   */
>  public final class SimpleCMYKColorSpace extends ColorSpace {
> -    private static final long serialVersionUID = 666L; // XXX Revise 
> UID value
> +    private static final long serialVersionUID = 5387117338644522424L;
>


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=windows-1252"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">+1<br>
      <br>
      -phil.<br>
      <br>
      On 05/06/2016 11:57 AM, Brian Burkhalter wrote:<br>
    </div>
    <blockquote
      cite="mid:AB80B022-88BB-433C-9268-EB2B87971BCA@oracle.com"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html;
        charset=windows-1252">
      Please review at your convenience.<br>
      <br>
      Issue:<span class="Apple-tab-span" style="white-space: pre;"> </span><a
        moz-do-not-send="true"
        href="https://bugs.openjdk.java.net/browse/JDK-8156459">https://bugs.openjdk.java.net/browse/JDK-8156459</a><br>
                
      Diff:<span class="Apple-tab-span" style="white-space: pre;"> </span>[1]<br>
      <br>
      Summary: Replace the current value of serialVersionUID with one
      created by the ‘serialver’ command.<br>
      <br>
      Thanks,<br>
      <br>
      Brian
      <div><br>
      </div>
      <div>[1] hg diff:</div>
      <div><br>
      </div>
      <div>
        <div style="margin: 0px; font-family: Courier;">---
a/src/java.desktop/share/classes/com/sun/imageio/plugins/common/SimpleCMYKColorSpace.java</div>
  <div style="margin: 0px; font-family: Courier;">+++
b/src/java.desktop/share/classes/com/sun/imageio/plugins/common/SimpleCMYKColorSpace.java</div>
  <div style="margin: 0px; font-family: Courier;">@@ -31,7 +31,7
          @@</div>
        <div style="margin: 0px; font-family: Courier;">  * color space.</div>
        <div style="margin: 0px; font-family: Courier;">  */</div>
        <div style="margin: 0px; font-family: Courier;"> public final
          class SimpleCMYKColorSpace extends ColorSpace {</div>
        <div style="margin: 0px; font-family: Courier;">-    private
          static final long serialVersionUID = 666L; // XXX Revise UID
          value</div>
        <div style="margin: 0px; font-family: Courier;">+    private
          static final long serialVersionUID = 5387117338644522424L;</div>
      </div>
      <div><br>
      </div>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic