[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6921664, , The amount of copies and the printer job name is not pa
From: prasanta sadhukhan <prasanta.sadhukhan () oracle ! com>
Date: 2016-04-15 5:59:50
Message-ID: 57108086.6050607 () oracle ! com
[Download RAW message or body]
Thanks Jay.
Please find the new webrev adding @Override annotation and I also
changed the copyright to 2016.
http://cr.openjdk.java.net/~psadhukhan/6921664/webrev.01/
Regards
Prasanta
On 4/15/2016 10:09 AM, Jayathirth D V wrote:
>
> Hi Prasanta,
>
> Change is working fine, +1.
>
> Additional comments : Please add your analysis in JBS and also
> remove/update the present Javadoc comment in test case and add
> Override annotation for subclasses present in test case.
>
> .
>
> Thanks,
>
> Jay
>
> *From:*prasanta sadhukhan
> *Sent:* Thursday, April 14, 2016 7:34 PM
> *To:* Philip Race
> *Cc:* 2d-dev@openjdk.java.net
> *Subject:* Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6921664, , The amount of
> copies and the printer job name is not passed to the implementing
>
> Hi Jay,
>
> Could you please give your +1 on this?
>
> Regards
> Prasanta
>
> On 4/13/2016 9:05 PM, Philip Race wrote:
>
> I have updated the synopsis, please use this in the commit :-
> "The number of copies and the job name are not passed to a 3rd
> party PrintService"
>
> Fix looks fine.
>
> -phil
>
>
> On 4/4/16, 4:21 AM, prasanta sadhukhan wrote:
>
> Hi All,
>
> Please review a fix for jdk9
> Bug: https://bugs.openjdk.java.net/browse/JDK-6921664
> webrev:
> http://cr.openjdk.java.net/~psadhukhan/6921664/webrev.00/
> <http://cr.openjdk.java.net/%7Epsadhukhan/6921664/webrev.00/>
>
> The issue was
> for a third party non-builtin print service, if the
> application sets the copies, jobname attribute these
> attributes are not passed to the third party print()
> implementation.
> This is because when we find there is a non-builtin print
> service, we call spoolService() in RasterPrinterJob
> which , even though it creates an attribute set via attributes
> = new HashPrintRequestAttributeSet();
> but it does not populate the attributes with the attributes
> set by the application, so when we call job.print(doc,
> attributes); we were passing attributes without any attribute
> set.
>
> I added the minimal copies and jobName attributes to the
> attribute list before calling the 3rdparty print implementation.
>
> Regards
> Prasanta
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Thanks Jay.<br>
Please find the new webrev adding @Override annotation and I also
changed the copyright to 2016.<br>
<a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~psadhukhan/6921664/webrev.01/">http://cr.openjdk.java.net/~psadhukhan/6921664/webrev.01/</a><br>
<br>
Regards<br>
Prasanta<br>
<div class="moz-cite-prefix">On 4/15/2016 10:09 AM, Jayathirth D V
wrote:<br>
</div>
<blockquote cite="mid:22fa6ba2-b133-4120-a5fa-9aedb54543da@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.overlay-icon
{mso-style-name:overlay-icon;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi
Prasanta,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> \
</o:p></span></p> <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Change
is working fine, +1.<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Additional
comments : Please add your analysis in JBS and also
remove/update the present Javadoc comment in test case and
add Override annotation for subclasses present in test \
case.<o:p></o:p></span></p> <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> \
.</o:p></span></p> <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Jay
<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> \
</o:p></span></p> <div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
prasanta sadhukhan <br>
<b>Sent:</b> Thursday, April 14, 2016 7:34 PM<br>
<b>To:</b> Philip Race<br>
<b>Cc:</b> <a class="moz-txt-link-abbreviated" \
href="mailto:2d-dev@openjdk.java.net">2d-dev@openjdk.java.net</a><br> \
<b>Subject:</b> Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6921664, , The amount of copies \
and the printer job
name is not passed to the implementing<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi Jay,<br>
<br>
Could you please give your +1 on this?<br>
<br>
Regards<br>
Prasanta<o:p></o:p></p>
<div>
<p class="MsoNormal">On 4/13/2016 9:05 PM, Philip Race \
wrote:<o:p></o:p></p> </div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">I have updated the synopsis, please use
this in the commit :-<br>
"The number of copies and the job name are not passed to a
3rd party PrintService"<br>
<br>
Fix looks fine.<br>
<br>
-phil<br>
<br>
<br>
On 4/4/16, 4:21 AM, prasanta sadhukhan wrote: <o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Hi All, <br>
<br>
Please review a fix for jdk9 <br>
Bug: <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-6921664">https://bugs.openjdk.java.net/browse/JDK-6921664</a>
<br>
webrev: <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Epsadhukhan/6921664/webrev.00/">http://cr.openjdk.java.net/~psadhukhan/6921664/webrev.00/</a>
<br>
<br>
The issue was <br>
for a third party non-builtin print service, if the
application sets the copies, jobname attribute these
attributes are not passed to the third party print()
implementation. <br>
This is because when we find there is a non-builtin print
service, we call spoolService() in RasterPrinterJob <br>
which , even though it creates an attribute set via
attributes = new HashPrintRequestAttributeSet(); <br>
but it does not populate the attributes with the
attributes set by the application, so when we call
job.print(doc, attributes); we were passing attributes
without any attribute set. <br>
<br>
I added the minimal copies and jobName attributes to the
attribute list before calling the 3rdparty print
implementation. <br>
<br>
Regards <br>
Prasanta <o:p></o:p></p>
</blockquote>
</blockquote>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic