[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8134986: Incorrect use of ConcurrentHashMap.contains in SunFontManager.jav
From:       Jennifer Godinez <jennifer.godinez () oracle ! com>
Date:       2016-04-14 19:30:53
Message-ID: 570FEFED.3040900 () oracle ! com
[Download RAW message or body]

Looks good.

Jennifer
On 04/04/2016 03:33 PM, Phil Race wrote:
> https://bugs.openjdk.java.net/browse/JDK-8134986
>
> When converted from a HashSet to a HashMap contains() should have
> changed to containsKey(). It does not lead to duplicate fonts because
> it is caught later on but it might lead to wasted work
>
> One line fix in line below
>
> diff --git 
> a/src/java.desktop/share/classes/sun/font/SunFontManager.java 
> b/src/java.desktop/share/classes/sun/font/SunFontManager.java
> --- a/src/java.desktop/share/classes/sun/font/SunFontManager.java
> +++ b/src/java.desktop/share/classes/sun/font/SunFontManager.java
> @@ -1843,7 +1843,7 @@
>
>      private PhysicalFont registerFontFile(String file) {
>          if (new File(file).isAbsolute() &&
> -            !registeredFonts.contains(file)) {
> +            !registeredFonts.containsKey(file)) {
>              int fontFormat = FONTFORMAT_NONE;
>              int fontRank = Font2D.UNKNOWN_RANK;
>              if (ttFilter.accept(null, file)) {
>
>
> -phil.
>

[prev in list] [next in list] [prev in thread] [next in thread]