[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9] Review Request: 7102282 TEST_BUG: sun/java2d/OpenGL/GradientPaints.java sho
From:       prasanta sadhukhan <prasanta.sadhukhan () oracle ! com>
Date:       2016-04-14 14:13:47
Message-ID: 570FA2CB.5000606 () oracle ! com
[Download RAW message or body]

Looks good to me.

Regards
Prasanta
On 4/14/2016 6:42 PM, Sergey Bylokhov wrote:
> On 13.04.16 14:53, prasanta sadhukhan wrote:
>> I guess you forgot to add 7102282 to the bugid.
>
> Thanks for review! The fix is updated:
> http://cr.openjdk.java.net/~serb/7102282/webrev.01
>
>>
>> Regards
>> Prasanta
>>>
>>> On 04/13/2016 01:37 AM, Sergey Bylokhov wrote:
>>>> Hello,bu
>>>> Please review the fix for jdk9.
>>>>
>>>> This test uncover a few issues:
>>>> Test bug:
>>>>   - Fail on HiDPI system, because the test tries to check the 
>>>> rendering
>>>> to the BufferedImage and VolaileImage using some threshold. Fixed 
>>>> by the
>>>> "-Dsun.java2d.uiScale=1" option.
>>>>
>>>> jdk bug:
>>>>   - timeout error (in the bug the value 800 is suggested). It seems a
>>>> duplicate of JDK-8041129 [1]. Anyway 800 is to big, and should be
>>>> considered as a jdk bug(if will be reproduced on the latest jdk9).
>>>>   - Incorrect rendering on some systems and video cards (especially on
>>>> linux), is covered by JDK-7124403 [2]
>>>>
>>>> Since OGL performance should be fixed already, I updated the test only
>>>> for the retina case. After the fix I think the test is ok, and other
>>>> possible failures should be considered as a jdk bugs.
>>>>
>>>> I also create a new bug JDK-8154103 [3] to check the performance of
>>>> XRender pipeline, it is slower than x11 and ogl.
>>>>
>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8041129
>>>> [2] https://bugs.openjdk.java.net/browse/JDK-7124403
>>>> [2] https://bugs.openjdk.java.net/browse/JDK-8154103
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-7102282
>>>> Webrev can be found at:
>>>> http://cr.openjdk.java.net/~serb/7102282/webrev.00
>>>>
>>>
>>
>
>

[prev in list] [next in list] [prev in thread] [next in thread]