[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR 8149558: [TEST] add regression test for JDK-8150154
From:       Alexander Stepanov <alexander.v.stepanov () oracle ! com>
Date:       2016-03-25 12:27:14
Message-ID: 56F52EA2.3000506 () oracle ! com
[Download RAW message or body]

Thanks!

On 3/25/2016 3:25 PM, Sergey Bylokhov wrote:
> +1
>
> On 24.03.16 20:18, Alexander Stepanov wrote:
>> Hello Sergey,
>>
>> Sorry, could you please look at the new test once more?
>>
>> the following lines
>>   124         // some type checks: avoid IO exceptions
>>   125
>>   126         if ((format.equals("jpeg") || format.equals("bmp")) &&
>>   127             pair.contains("USHORT_GRAY")) {
>>   128             return;
>>   129         }
>>   130
>>   131         if (format.equals("bmp") &&
>>   132             (pair.contains("ARGB") || pair.contains("ABGR"))) {
>>   133             return;
>>   134         }
>>
>> were replaced with
>>   124         // some type checks: avoid IO exceptions
>>   125         if ((format.equals("jpeg") || format.equals("bmp")) &&
>>   126             (pair.contains("USHORT_GRAY") ||
>>   127              pair.contains("ARGB") || pair.contains("ABGR"))) {
>>   128             return;
>>   129         }
>>
>> to make possible to run the test with OpenJDK (didn't check that
>> initially).
>>
>> Thanks,
>> Alexander
>>
>> On 3/24/2016 2:02 PM, Sergey Bylokhov wrote:
>>> Looks fine to me.
>>>
>>> On 23.03.16 12:46, Alexander Stepanov wrote:
>>>> Hello, Sergey,
>>>>
>>>>  > Should we also test bmp and jpg?
>>>> covered as well
>>>>
>>>>  > all of them have a white color and same size
>>>> for the 2nd version the images used for the 1st and 2nd checks have
>>>> different sizes and colors
>>>>
>>>> Thanks,
>>>> Alexander
>>>>
>>>>
>>>> On 3/22/2016 8:27 PM, Sergey Bylokhov wrote:
>>>>> On 22.03.16 19:31, Alexander Stepanov wrote:
>>>>>> Sorry, just a reminder.
>>>>>
>>>>> Can you provide an information what was changed in this version?
>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Alexander
>>>>>>
>>>>>> On 3/15/2016 7:12 PM, Alexander Stepanov wrote:
>>>>>>> Please see the updated fix:
>>>>>>> http://cr.openjdk.java.net/~avstepan/8149558/webrev.01/
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Alexander
>>>>>>>
>>>>>>> On 2/26/2016 6:54 PM, Alexander Stepanov wrote:
>>>>>>>> > Should we also test bmp and jpg?
>>>>>>>>
>>>>>>>> couldn't use writer for these formats "as is" (simply
>>>>>>>> "writer.write(img)") - this causes IOExceptions. 
>>>>>>>> JPEGImageWriteParam
>>>>>>>> or BMPImageWriteParam should be used and another signature for
>>>>>>>> write() method. Extended test logic looks quite bulky with all 
>>>>>>>> this
>>>>>>>> additions.
>>>>>>>>
>>>>>>>> > but you do not check that the saved information actually
>>>>>>>> relates to
>>>>>>>> the particular image (all of them have a white color and same 
>>>>>>>> size)
>>>>>>>>
>>>>>>>> even in this case we have color check failure for pair
>>>>>>>> (TYPE_USHORT_565_RGB, TYPE_USHORT_555_RGB). but yes, probably 
>>>>>>>> it is
>>>>>>>> better to use different images for the 1st and 2nd write attempts.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Alexander
>>>>>>>>
>>>>>>>> On 2/26/2016 6:06 PM, Sergey Bylokhov wrote:
>>>>>>>>> Should we also test bmp and jpg? You tested a different BI 
>>>>>>>>> formats,
>>>>>>>>> but you do not check that the saved information actually 
>>>>>>>>> relates to
>>>>>>>>> the particular image(all of them have a white color and same 
>>>>>>>>> size).
>>>>>>>>> So you will not notice if the Writer will write the same(first)
>>>>>>>>> image in all subsequent calls.
>>>>>>>>>
>>>>>>>>> On 25.02.16 18:17, Alexander Stepanov wrote:
>>>>>>>>>> Sorry, just a reminder.
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>> Alexander
>>>>>>>>>>
>>>>>>>>>> On 2/12/2016 1:35 PM, Alexander Stepanov wrote:
>>>>>>>>>>> Hello,
>>>>>>>>>>>
>>>>>>>>>>> Could you please review the following fix
>>>>>>>>>>> http://cr.openjdk.java.net/~avstepan/8149558/webrev.00/
>>>>>>>>>>> for
>>>>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8149558
>>>>>>>>>>>
>>>>>>>>>>> Just a single regression test added (still failing), plus minor
>>>>>>>>>>> correction for other test.
>>>>>>>>>>>
>>>>>>>>>>> Thanks,
>>>>>>>>>>> Alexander
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>
>
>

[prev in list] [next in list] [prev in thread] [next in thread]