[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8151590, , "ALL" radio button is not selected in printDialog when
From: Jayathirth D V <jayathirth.d.v () oracle ! com>
Date: 2016-03-24 8:00:30
Message-ID: 0d5e6bcd-fa2b-43b5-b0aa-ab9bac982b6d () default
[Download RAW message or body]
Hi Prasanta,
Here we are giving priority to setDefaultSelection() over setXXXPage() and since we \
are following the same rule among all platforms changes are fine.
Before and after change test is working fine. But test case needs little changes:
1) There are unused imports :
Line 31 import java.awt.Component;
Line 40 import javax.swing.JOptionPane;
2) There are places in test case where we have changes over 80 character \
length :
Line 81 PrintJob pj = tk.getPrintJob(new JFrame(), \
"testing the attribute setting ", job, page);
Line 102 + " If ALL radio button is selected, press \
PASS else press FAIL";
Apart from this test and code changes are fine.
Thanks,
Jay
From: Philip Race
Sent: Wednesday, March 23, 2016 9:07 PM
To: prasanta sadhukhan
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8151590, , "ALL" radio button is not \
selected in printDialog when we call DefaultSelectionType.ALL in windows
Hi,
There are three typos which you need to fix before you push
No need for another webrev.
79 // seeting this dialog to native pritdialog
100 + " A print dialog wil lbe shown.\n "
-phil.
On 3/17/16, 1:35 AM, prasanta sadhukhan wrote:
Hi Phil,
Please find the updated webrev:
http://cr.openjdk.java.net/~psadhukhan/8151590/webrev.02/
Regards
Prasanta
On 3/17/2016 12:20 AM, Philip Race wrote:
As I mentioned off-line please remove the extraneous stuff
from the test. And why is the (c) 2015 ?
-phil.
On 3/11/16, 4:06 AM, prasanta sadhukhan wrote:
Please find modified webrev with updated testcase.
http://cr.openjdk.java.net/~psadhukhan/8151590/webrev.01/
Regards
Prasanta
On 3/10/2016 4:04 PM, prasanta sadhukhan wrote:
Hi Phil,
Bug: https://bugs.openjdk.java.net/browse/JDK-8151590
webrev: http://cr.openjdk.java.net/~psadhukhan/8151590/webrev.00/
The issue is if application calls
JobAttributes.setDefaultSelection(JobAttributes.DefaultSelectionType.ALL);
along with
JobAttributes.setFromPage(2);
JobAttributes.setToPage(5);
then "Page" radio button is selected in windows. In linux and mac, "All" radio button \
is selected. Although the spec is not very clear as to what should get preference, \
it seems logically DefaultSelection should hold preference.
This is a regression from 8061267 where PD_PAGENUMS was added to the flags resulting \
in "Page" radio button getting selected. I added a fix to add PD_PAGENUMS to the \
flags only if the selection attribute is not "PD_ALLPAGES" [which gets selected when \
JobAttributes.setDefaultSelection(JobAttributes.DefaultSelectionType.ALL); is called] \
I tested 8061267 testcase behaviour is same with this fix.
Regards
Prasanta
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:195041875;
mso-list-type:hybrid;
mso-list-template-ids:-1749397084 67698705 67698713 67698715 67698703 67698713 \
67698715 67698703 67698713 67698715;} @list l0:level1
{mso-level-text:"%1\)";
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level2
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level3
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level4
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level5
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level6
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level7
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level8
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level9
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-US link=blue \
vlink=purple><div class=WordSection1><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Hi \
Prasanta,<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Here we are \
giving priority to setDefaultSelection() over setXXXPage() and since we are following \
the same rule among all platforms changes are fine. <o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Before and \
after change test is working fine. But test case needs little \
changes:<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoListParagraph style='text-indent:-.25in;mso-list:l0 level1 lfo1'><![if \
!supportLists]><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><span \
style='mso-list:Ignore'>1)<span style='font:7.0pt "Times New \
Roman"'> </span></span></span><![endif]><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>There are \
unused imports :<o:p></o:p></span></p><p class=MsoListParagraph \
style='margin-left:1.0in'><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Line 31 \
import java.awt.Component;<o:p></o:p></span></p><p class=MsoListParagraph \
style='margin-left:1.0in'><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Line 40 \
import javax.swing.JOptionPane;<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoListParagraph style='text-indent:-.25in;mso-list:l0 level1 lfo1'><![if \
!supportLists]><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><span \
style='mso-list:Ignore'>2)<span style='font:7.0pt "Times New \
Roman"'> </span></span></span><![endif]><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>There are \
places in test case where we have changes over 80 character length \
:<o:p></o:p></span></p><p class=MsoListParagraph style='margin-left:1.0in'><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Line 81 \
PrintJob pj = tk.getPrintJob(new JFrame(), "testing the attribute setting \
", job, page);<o:p></o:p></span></p><p class=MsoListParagraph \
style='margin-left:1.0in'><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Line 102 \
+ " If ALL radio button is selected, press PASS else press \
FAIL";<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Apart from \
this test and code changes are fine.<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Thanks,<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Jay<o:p></o:p></span></p><div><div \
style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p \
class=MsoNormal><b><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext'>From:</span></b><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext'> Philip \
Race <br><b>Sent:</b> Wednesday, March 23, 2016 9:07 PM<br><b>To:</b> prasanta \
sadhukhan<br><b>Cc:</b> 2d-dev@openjdk.java.net<br><b>Subject:</b> Re: [OpenJDK \
2D-Dev] [9] RFR: JDK-8151590, , "ALL" radio button is not selected in \
printDialog when we call DefaultSelectionType.ALL in \
windows<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal style='margin-bottom:12.0pt'>Hi,<br><br>There are three typos which \
you need to fix before you push<br>No need for another webrev.<o:p></o:p></p><pre> \
79 // seeting this dialog to native pritdialog<o:p></o:p></pre><pre> \
100 + " A print dialog wil lbe shown.\n \
"<o:p></o:p></pre><p class=MsoNormal><br>-phil.<br><br>On 3/17/16, 1:35 AM, \
prasanta sadhukhan wrote: <o:p></o:p></p><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal>Hi Phil, \
<br><br>Please find the updated webrev: <br><a \
href="http://cr.openjdk.java.net/~psadhukhan/8151590/webrev.02/">http://cr.openjdk.java.net/~psadhukhan/8151590/webrev.02/</a> \
<br><br>Regards <br>Prasanta <br>On 3/17/2016 12:20 AM, Philip Race wrote: \
<br><br><o:p></o:p></p><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p \
class=MsoNormal>As I mentioned off-line please remove the extraneous stuff <br>from \
the test. And why is the (c) 2015 ? <br><br>-phil. <br><br>On 3/11/16, 4:06 AM, \
prasanta sadhukhan wrote: <br><br><o:p></o:p></p><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><br>Please find \
modified webrev with updated testcase. <br><a \
href="http://cr.openjdk.java.net/~psadhukhan/8151590/webrev.01/">http://cr.openjdk.java.net/~psadhukhan/8151590/webrev.01/</a> \
<br><br>Regards <br>Prasanta <br>On 3/10/2016 4:04 PM, prasanta sadhukhan wrote: \
<br><br><o:p></o:p></p><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p \
class=MsoNormal>Hi Phil, <br><br>Bug: <a \
href="https://bugs.openjdk.java.net/browse/JDK-8151590">https://bugs.openjdk.java.net/browse/JDK-8151590</a> \
<br>webrev: <a href="http://cr.openjdk.java.net/~psadhukhan/8151590/webrev.00/">http://cr.openjdk.java.net/~psadhukhan/8151590/webrev.00/</a> \
<br><br>The issue is if application calls \
<br>JobAttributes.setDefaultSelection(JobAttributes.DefaultSelectionType.ALL); \
<br>along with <br>JobAttributes.setFromPage(2); \
<br> JobAttributes.setToPage(5); <br><br>then "Page" radio button is \
selected in windows. In linux and mac, "All" radio button is selected. \
<br>Although the spec is not very clear as to what should get preference, it seems \
logically DefaultSelection should hold preference. <br><br>This is a regression from \
8061267 where PD_PAGENUMS was added to the flags resulting in "Page" radio \
button getting selected. <br>I added a fix to add PD_PAGENUMS to the flags only if \
the selection attribute is not "PD_ALLPAGES" [which gets selected when \
JobAttributes.setDefaultSelection(JobAttributes.DefaultSelectionType.ALL); is called] \
<br><br>I tested 8061267 testcase behaviour is same with this fix. <br><br>Regards \
<br>Prasanta <o:p></o:p></p></blockquote><p \
class=MsoNormal><o:p> </o:p></p></blockquote></blockquote><p \
class=MsoNormal><o:p> </o:p></p></blockquote></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic