[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6379088, , Suboptimal expression in
From: Phil Race <philip.race () oracle ! com>
Date: 2016-03-16 20:22:36
Message-ID: 56E9C08C.2070308 () oracle ! com
[Download RAW message or body]
+1
noreg-hard may be better than noreg-trivial.
-phil.
On 03/16/2016 01:09 PM, Sergey Bylokhov wrote:
> +1
>
> On 16.03.16 12:16, Jayathirth D V wrote:
>> Change is fine. Looks like this is the only place in
>> ImageTypeSpecifier where we are not using short-circuit logical "or".
>>
>> -----Original Message-----
>> From: prasanta sadhukhan
>> Sent: Tuesday, March 15, 2016 5:36 PM
>> To: Sergey Bylokhov; Jayathirth D V; 2d-dev@openjdk.java.net
>> Subject: [9] RFR: JDK-6379088,,Suboptimal expression in
>> javax.imageio.ImageTypeSpecifier.getBitsPerBand(int)
>>
>> Hi All,
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-6379088
>> webrev: http://cr.openjdk.java.net/~psadhukhan/6379088/webrev.00/
>>
>> Please review a simple fix where we should be using short-circuit
>> logical operators so that if left side of the expression is false,
>> right side will not be evaluated.
>> I intend to put noreg-trivial label for this fix.
>>
>> Regards
>> Prasanta
>>
>
>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic