[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR 8148886: SEGV in sun.java2d.marlin.Renderer._endRendering
From:       Laurent_Bourgès <bourges.laurent () gmail ! com>
Date:       2016-02-23 21:25:36
Message-ID: CAKjRUT5Z4JtAWP3ciV4SUe==yu82e5GMVBOvv0H2wVYT4dLp8Q () mail ! gmail ! com
[Download RAW message or body]

Phil & Jim,

Thanks for your reviews.

Changeset pushed:
http://hg.openjdk.java.net/jdk9/client/jdk/rev/4f7f1c6d613d

2016-02-23 2:05 GMT+01:00 Philip Race <philip.race@oracle.com>:

> This all looks good to me. Sorry it took a long time to get to it.
>

That's fine.
I wanted to push the SEGV fix as fast as possible but your comments &
suggestions were interesting and improved definitely the proposed solution.

One thing that currently doesn't matter and perhaps never will is
> HardReference perhapscould also over-ride clear() :
>
> public void clear() {
>   super.clear();
>   strongRef = null;
> }
>
> strongRef must no longer be final in this case.
>
> But if anyone ever needs that they can make the change ..
>

That looks interesting but I doubt someone would need to clear such
HardReference (but who knows ?).
(for now I prefer keeping the strongRef field 'final' to let the compiler
perform optimizations)


> So approved.
>
> -phil.
>

Sincerly,
Laurent

[Attachment #3 (text/html)]

<div dir="ltr"><div>Phil &amp; Jim,<br><br></div>Thanks for your reviews. \
<br><br>Changeset pushed:<br><a \
href="http://hg.openjdk.java.net/jdk9/client/jdk/rev/4f7f1c6d613d">http://hg.openjdk.java.net/jdk9/client/jdk/rev/4f7f1c6d613d</a><br><div><div \
class="gmail_extra"><br><div class="gmail_quote">2016-02-23 2:05 GMT+01:00 Philip \
Race <span dir="ltr">&lt;<a href="mailto:philip.race@oracle.com" \
target="_blank">philip.race@oracle.com</a>&gt;</span>:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">  
    
  
  <div bgcolor="#FFFFFF" text="#000000">
    This all looks good to me. Sorry it took a long time to get to \
it.<br></div></blockquote><div><br></div><div>That&#39;s fine.<br>I wanted to push \
the SEGV fix as fast as possible but your comments &amp; suggestions were interesting \
and improved definitely the proposed solution.<br><br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000">  
    One thing that currently doesn&#39;t matter and perhaps never will is<br>
    HardReference perhapscould also over-ride clear() :<br>
    <br>
    public void clear() {<br>
       super.clear();<br>
       strongRef = null;<br>
    }<br>
    <br>
    strongRef must no longer be final in this case.<br>
    <br>
    But if anyone ever needs that they can make the change \
..<br></div></blockquote><div><br></div><div>That looks interesting but I doubt \
someone would need to clear such HardReference (but who knows ?).<br>(for now I \
prefer keeping the strongRef field &#39;final&#39; to let the compiler perform \
optimizations)<br></div><div>  </div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000">  
    So approved.<span class=""><font color="#888888"><br>
    <br>
    -phil.</font></span></div></blockquote><div><br></div><div>Sincerly,<br></div><div>Laurent</div></div></div></div></div>




[prev in list] [next in list] [prev in thread] [next in thread]