[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9] Review request for 8073400: Some Monospaced logical fonts have a different 
From:       dmitry markov <dmitry.markov () oracle ! com>
Date:       2016-02-17 13:01:41
Message-ID: 56C46F35.6030107 () oracle ! com
[Download RAW message or body]

Hello Phil,

Thank you for the review.

According to unicode table the characters u201c and u201d are in General 
Punctuation block, see 
http://unicode-table.com/en/blocks/general-punctuation/
Many characters from this block are not supported by Courier New. So I 
do not think we need to remove the whole block from the exclusion range, 
since it will not have any effect except few characters like u201c and 
u201d. That's why I removed such small characters set (u2018 - u201F) 
from the exclusion range, but I can change this if it is necessary.

At the same time the characters set (u2018 - u201F) is supported by 
Arial and Times New Roman which are mapped to other logical fonts. The 
adjusted exclusion range seems 'quite safe' from this point of view. So 
I do not think we need to modify any code such as FontConfiguration 
class and so on to apply these changes only to monospaced fonts. Please 
correct me if I am wrong.

Adding i18n-dev.

Internationalization team,
Could you review a small change in windows.fontconfig.properties, please?

     bug: https://bugs.openjdk.java.net/browse/JDK-8073400
     webrev: http://cr.openjdk.java.net/~dmarkov/8073400/jdk9/webrev.00/

Problem description:
On Windows some characters (in particular, left and right double 
quotation marks) have width differing from other characters' widths, 
when Monospaced logical font is used.
The default monospaced font for windows platform is Courier New. It 
contains the desired characters, (i.e. '\u201c' and '\u201d'). However 
the characters are in 'exclusion ranges' for this font due to settings 
in windows.fontconfig.properties. So when we try to obtain glyphs for 
these characters and calculate their bounds, we fallback to another font 
(Lucida) and use its glyphs.

Fix:
Remove the following set of characters u2018 - u201F from the exclusion 
ranges.

Thank you in advance,
Dmitry
On 10/02/2016 23:25, Phil Race wrote:
> I expect the exclusion range is there for a reason.
> I think (guess) that the intent was that where there is a sequence 
> like this :
>
> sequence.sansserif.x-windows-950=alphabetic,chinese-ms950,dingbats,symbol,chinese-ms950-extb 
>
>
> then those code points should come from the chinese font.
>
> Perhaps your adjusted exclusion range should apply only to the 
> monospaced fonts
> which are already putting the locale font first.
>
> Unfortunately it doesn't appear that this is possible with the 
> supported syntax
> https://docs.oracle.com/javase/1.5.0/docs/guide/intl/fontconfig.html#windows 
>
>
> i.e it supports selection only by charactersubsetname, not also by 
> logicalfontname.
> But you should check the code to see if this is in fact the case.
> There may need to be a non-ideal decision or a revision to that spec. 
> and its
> supporting code.
>
> And why be so narrow ? It seems you have made an even odder situation
> in having just those two code points 'un'-excluded.
> The argument that those were the two a customer complained about does not
> hold up very well.
>
> I think you should also run this whole change+discussion by i18n-dev ..
>
>
> -phil.
>
> On 01/14/2016 02:32 AM, dmitry markov wrote:
>> Hello,
>>
>> Could you review the fix for jdk9, please?
>>
>>     bug: https://bugs.openjdk.java.net/browse/JDK-8073400
>>     webrev: http://cr.openjdk.java.net/~dmarkov/8073400/jdk9/webrev.00/
>>
>> Problem description:
>> On Windows some characters (in particular, left and right double 
>> quotation marks) have width differing from other characters' widths, 
>> when Monospaced logical font is used.
>> The default monospaced font for windows platform is Courier New. It 
>> contains the desired characters, (i.e. '\u201c' and '\u201d'). 
>> However the characters are in 'exclusion ranges' for this font due to 
>> settings in windows.fontconfig.properties. So when we try to obtain 
>> glyphs for these characters and calculate their bounds, we fallback 
>> to another font (Lucida) and use its glyphs.
>>
>> Fix:
>> Remove the following set of characters u2018 - u201F from the 
>> exclusion ranges.
>>
>> Thanks,
>> Dmitry
>

[prev in list] [next in list] [prev in thread] [next in thread]