[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8148431, , PrinterJob.pageDialog() does not support multi-mon,
From:       Philip Race <philip.race () oracle ! com>
Date:       2016-01-28 14:57:28
Message-ID: 56AA2C58.70808 () oracle ! com
[Download RAW message or body]

This is the same actual logic as the other bug about the print dialog.
They actually invoke the same code, just in a different mode.
We would want the logic the same I think.
I would not have filed a "new bug"  to handle this case.
I would have just added it into the existing bug.
Please close out this new bug as a duplicate and merge the two webrevs
so we can see it all at once.

-phil.

On 1/27/16, 10:27 PM, prasanta sadhukhan wrote:
> Rectified the webrev link:
>
> On 1/28/2016 11:50 AM, prasanta sadhukhan wrote:
>> Hi All,
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8148431 
>> <https://bugs.openjdk.java.net/browse/JDK-8148431>
>> webrev:
> http://cr.openjdk.java.net/~psadhukhan/8148431/webrev.00/
>>
>>
>> Please review a fix in continuation with JDK-8138749 . It is seen that
>> PrinterJob.pageDialog(attr set) also does not support multi-monitor 
>> setup. When this API is invoked, the page setup dialog is always 
>> displayed on the default screen device regardless of where the 
>> application is running.
>> This is because this method
>> uses ServiceDialog class for creating the dialog and that indeed 
>> supports passing a GC in which we would like to have the dialog. But 
>> printer job always uses the GraphicsConfig of the default screen device
>> resulting in page dialog to be shown on primary device/monitor.
>>
>> So, the fix is to use the GraphicsConfig of the current active window 
>> while showing the dialog.
>>
>> Regards
>> Prasanta 
>

[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    This is the same actual logic as the other bug about the print
    dialog.<br>
    They actually invoke the same code, just in a different mode.<br>
    We would want the logic the same I think. <br>
    I would not have filed a "new bug"   to handle this case.<br>
    I would have just added it into the existing bug.<br>
    Please close out this new bug as a duplicate and merge the two
    webrevs<br>
    so we can see it all at once.<br>
    <br>
    -phil.<br>
    <br>
    On 1/27/16, 10:27 PM, prasanta sadhukhan wrote:
    <blockquote cite="mid:56A9B4E2.8080008@oracle.com" type="cite">
      <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
      Rectified the webrev link:<br>
      <br>
      <div class="moz-cite-prefix">On 1/28/2016 11:50 AM, prasanta
        sadhukhan wrote:<br>
      </div>
      <blockquote cite="mid:56A9B318.7010801@oracle.com" type="cite">
        <meta http-equiv="content-type" content="text/html;
          charset=UTF-8">
        Hi All, <br>
        <br>
        Bug: <a moz-do-not-send="true" class="moz-txt-link-freetext"
          href="https://bugs.openjdk.java.net/browse/JDK-8138749">https://bugs.openjdk.java.net/browse/</a><a
  moz-do-not-send="true" class="issue-link"
          data-issue-key="JDK-8148431"
          href="https://bugs.openjdk.java.net/browse/JDK-8148431"
          id="key-val" rel="4863136">JDK-8148431</a> <br>
        webrev:</blockquote>
      <a moz-do-not-send="true" class="moz-txt-link-freetext"
        href="http://cr.openjdk.java.net/%7Epsadhukhan/8148431/webrev.00/">http://cr.openjdk.java.net/~psadhukhan/8148431/webrev.00/</a><br>
  <blockquote cite="mid:56A9B318.7010801@oracle.com" type="cite"> <br>
        <br>
        Please review a fix in continuation with JDK-8138749 . It is
        seen that<br>
        PrinterJob.pageDialog(attr set) also does not support
        multi-monitor setup. When this API is invoked, the page setup
        dialog is always displayed on the default screen device
        regardless of where the application is running. <br>
        This is because this method <br>
        uses ServiceDialog class for creating the dialog and that indeed
        supports passing a GC in which we would like to have the dialog.
        But printer job always uses the GraphicsConfig of the default
        screen device <br>
        resulting in page dialog to be shown on primary device/monitor.
        <br>
        <br>
        So, the fix is to use the GraphicsConfig of the current active
        window while showing the dialog.<br>
        <br>
        Regards <br>
        Prasanta </blockquote>
      <br>
    </blockquote>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic