[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] <OpenJDK 2D-Dev> Review request for JDK - 8041501 : ImageIO reader is not capab
From: Phil Race <philip.race () oracle ! com>
Date: 2016-01-21 18:03:38
Message-ID: 56A11D7A.2020603 () oracle ! com
[Download RAW message or body]
Approved. Please send a request to commit this change to the 8u-dev list.
-phil.
On 01/20/2016 10:20 PM, Jayathirth D V wrote:
>
> Hi,
>
> This is backport of the fix that is already merged into JDK9.
>
> _Please review the fix in JDK8u:_
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8041501
>
> Webrev : http://cr.openjdk.java.net/~jdv/8041501.8u/webrev.00/
> <http://cr.openjdk.java.net/%7Ejdv/8041501.8u/webrev.00/>
>
> Issue : Pink discoloration when we read JPEG images without JFIF &
> EXIF header and having no subsampling.
>
> Root cause : We are overriding JPEG color space set in IJG library at
> imageioJPEG.c without checking component ID's properly when JFIF &
> EXIF are not there. Decision to change color space is solely done
> consulting sampling factors.
>
> Solution : Added extra check to verify component ID's also before
> changing color space determined by IJG library when there is no JFIF &
> EXIF header.
>
> Thanks,
>
> Jay
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Approved. Please send a request to
commit this change to the 8u-dev list.<br>
<br>
-phil.<br>
<br>
On 01/20/2016 10:20 PM, Jayathirth D V wrote:<br>
</div>
<blockquote cite="mid:cd421ed4-fed1-456b-9a9b-2774a0f44986@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">This is backport of the fix that is already
merged into JDK9.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><u>Please review the fix in JDK8u:</u><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Bug : <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8041501">https://bugs.openjdk.java.net/browse/JDK-8041501</a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Webrev : <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ejdv/8041501.8u/webrev.00/">http://cr.openjdk.java.net/~jdv/8041501.8u/webrev.00/</a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Issue : Pink discoloration when we read
JPEG images without JFIF & EXIF header and having no
subsampling.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Root cause : We are overriding JPEG color
space set in IJG library at imageioJPEG.c without checking
component ID’s properly when JFIF & EXIF are not there.
Decision to change color space is solely done consulting
sampling factors.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Solution : Added extra check to verify
component ID’s also before changing color space determined by
IJG library when there is no JFIF & EXIF header.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Jay<o:p></o:p></p>
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic