[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR 8146076: Fail of sun/java2d/marlin/CeilAndFloorTests.java with Jigsaw
From:       Laurent_Bourgès <bourges.laurent () gmail ! com>
Date:       2016-01-08 20:48:36
Message-ID: CAKjRUT76gW1EUdcJWKDSaLM70hj2Qm6m_-jG_4hVH+bXO=cSBg () mail ! gmail ! com
[Download RAW message or body]

Thanks,

I was also doubting if 2 reviewers were needed.

Will push it once the census page is updated.

Laurent
Le 8 janv. 2016 21:30, "Jim Graham" <james.graham@oracle.com> a =C3=A9crit =
:

> For something this minor and essentially just bookkeeping in a test's
> comments, 1 review is fine.  Phil is checking on your commit rights for t=
he
> repo so you can (hopefully soon) push it directly...
>
>                         ...jim
>
> On 1/8/16 12:21 AM, Laurent Bourg=C3=A8s wrote:
>
>> Hi,
>>
>> Another reviewer for this trivial test fix, please !
>>
>> Laurent
>>
>> Le 6 janv. 2016 23:29, "Philip Race" <philip.race@oracle.com
>> <mailto:philip.race@oracle.com>> a =C3=A9crit :
>>
>>>
>>> +1.
>>>
>>> -phil.
>>>
>>>
>>> On 1/6/16, 2:26 PM, Laurent Bourg=C3=A8s wrote:
>>>
>>>>
>>>> Hi,
>>>>
>>>> Please review this trivial fix for 2 Marlin tests to make them work
>>>> with jake:
>>>> http://cr.openjdk.java.net/~lbourges/marlin/marlin-8146076.0/
>>>>
>>> <http://cr.openjdk.java.net/%7Elbourges/marlin/marlin-8146076.0/>
>>
>>>
>>>>
>>>> I tested the patch with latest jtreg-4.2 (tip) and JDK9 jigsaw EA b99.
>>>>
>>>> Regards,
>>>> Laurent
>>>>
>>>
>>

[Attachment #3 (text/html)]

<p dir="ltr">Thanks,</p>
<p dir="ltr">I was also doubting if 2 reviewers were needed.</p>
<p dir="ltr">Will push it once the census page is updated.</p>
<p dir="ltr">Laurent</p>
<div class="gmail_quote">Le  8 janv. 2016 21:30, &quot;Jim Graham&quot; &lt;<a \
href="mailto:james.graham@oracle.com">james.graham@oracle.com</a>&gt; a écrit  :<br \
type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">For something this minor and \
essentially just bookkeeping in a test&#39;s comments, 1 review is fine.   Phil is \
checking on your commit rights for the repo so you can (hopefully soon) push it \
directly...<br> <br>
                                    ...jim<br>
<br>
On 1/8/16 12:21 AM, Laurent Bourgès wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Hi,<br>
<br>
Another reviewer for this trivial test fix, please !<br>
<br>
Laurent<br>
<br>
Le 6 janv. 2016 23:29, &quot;Philip Race&quot; &lt;<a \
href="mailto:philip.race@oracle.com" target="_blank">philip.race@oracle.com</a><br> \
&lt;mailto:<a href="mailto:philip.race@oracle.com" \
target="_blank">philip.race@oracle.com</a>&gt;&gt; a écrit :<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <br>
+1.<br>
<br>
-phil.<br>
<br>
<br>
On 1/6/16, 2:26 PM, Laurent Bourgès wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <br>
Hi,<br>
<br>
Please review this trivial fix for 2 Marlin tests to make them work with jake:<br>
<a href="http://cr.openjdk.java.net/~lbourges/marlin/marlin-8146076.0/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~lbourges/marlin/marlin-8146076.0/</a><br>
 </blockquote></blockquote>
&lt;<a href="http://cr.openjdk.java.net/%7Elbourges/marlin/marlin-8146076.0/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/%7Elbourges/marlin/marlin-8146076.0/</a>&gt;<br>
 <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"> <br>
<br>
I tested the patch with latest jtreg-4.2 (tip) and JDK9 jigsaw EA b99.<br>
<br>
Regards,<br>
Laurent<br>
</blockquote></blockquote>
<br>
</blockquote>
</blockquote></div>



[prev in list] [next in list] [prev in thread] [next in thread]