[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] RFR 6488522: PNG writer should permit setting compression level and iDAT chunk
From: Phil Race <philip.race () oracle ! com>
Date: 2015-12-16 22:31:35
Message-ID: 5671E647.5060102 () oracle ! com
[Download RAW message or body]
Looks good. I will push it shortly.
-phil.
On 12/15/2015 07:25 AM, Laurent Bourgès wrote:
> Sergey,
>
> thanks for your review.
>
> Could you or Phil push it for me once another reviewer is OK ?
>
> Laurent
>
>
> 2015-12-15 16:22 GMT+01:00 Sergey Bylokhov <Sergey.Bylokhov@oracle.com
> <mailto:Sergey.Bylokhov@oracle.com>>:
>
> Looks fine to me. Thanks.
>
>
> On 12/12/15 19:17, Laurent Bourgès wrote:
>
> Sergey,
>
> Here is my latest webrev:
> http://cr.openjdk.java.net/~lbourges/png/PNGWriter-6488522.3/
> <http://cr.openjdk.java.net/%7Elbourges/png/PNGWriter-6488522.3/>
>
> One more reviewer, please ?
>
>
> Probably it can be made local to the write method, but
> this version looks fine too.
>
>
> You're right. I will improve that, I did it too quickly.
>
> Fixed: it is clearer and simpler.
>
> Regards,
> Laurent
>
>
>
> --
> Best regards, Sergey.
>
>
>
>
> --
> --
> Laurent Bourgès
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Looks good. I will push it shortly.<br>
<br>
-phil.<br>
<br>
On 12/15/2015 07:25 AM, Laurent Bourgès wrote:<br>
</div>
<blockquote
cite="mid:CAKjRUT5hVA0RxBXOEt=KXKsQv6oqB4DkTx5u-Veadwq1kq+FXw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>Sergey,<br>
<br>
thanks for your review. <br>
</div>
<br>
Could you or Phil push it for me once another reviewer is OK ?<br>
<br>
</div>
Laurent<br>
<div>
<div><br>
<div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2015-12-15 16:22 GMT+01:00
Sergey Bylokhov <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:Sergey.Bylokhov@oracle.com"
target="_blank">Sergey.Bylokhov@oracle.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Looks
fine to me. Thanks.
<div class="HOEnZb">
<div class="h5"><br>
<br>
On 12/12/15 19:17, Laurent Bourgès wrote:<br>
<blockquote class="gmail_quote" style="margin:0
0 0 .8ex;border-left:1px #ccc
solid;padding-left:1ex">
Sergey,<br>
<br>
Here is my latest webrev:<br>
<a moz-do-not-send="true"
\
href="http://cr.openjdk.java.net/%7Elbourges/png/PNGWriter-6488522.3/"
rel="noreferrer" \
target="_blank">http://cr.openjdk.java.net/~lbourges/png/PNGWriter-6488522.3/</a><br> \
<br> One more reviewer, please ?<br>
<br>
<br>
<blockquote class="gmail_quote"
style="margin:0 0 0 .8ex;border-left:1px
#ccc solid;padding-left:1ex">
Probably it can be made local to the write
method, but this version looks fine too.<br>
</blockquote>
<br>
You're right. I will improve that, I did
it too quickly.<br>
<br>
Fixed: it is clearer and simpler.<br>
<br>
Regards,<br>
Laurent<br>
</blockquote>
<br>
<br>
</div>
</div>
<span class="HOEnZb"><font color="#888888">
-- <br>
Best regards, Sergey.<br>
</font></span></blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
<div class="gmail_signature">-- <br>
Laurent Bourgès</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic