[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] RFR: 8144245: [PIT] javax/imageio/plugins/shared/WriteAfterAbort.java
From: Brian Burkhalter <brian.burkhalter () oracle ! com>
Date: 2015-12-08 17:13:49
Message-ID: 18860736-652C-448F-A3BD-6707A303AA01 () oracle ! com
[Download RAW message or body]
The pre-existing WriteAfterAbort passes for all plugins; WriteToSequenceAfterAbort \
passes for TIFF but fails for GIF and JPEG, which are the only other plugins which \
can write sequences. This could be a problem in the test itself but I did not \
investigate further.
I see also that I need to delete lines 204-206 of WriteToSequenceAfterAbort.java.
Brian
On Dec 7, 2015, at 6:29 PM, Phil Race <philip.race@oracle.com> wrote:
> I suppose this modified test must pass for all the plugins ?
>
> > http://cr.openjdk.java.net/~bpb/8144245/webrev.01/
> >
> > Added WriteToSequenceAfterAbort test.
> > Corrected TIFFImageWriter to pass both tests (needed to save and restore some \
> > extra state, mainly positions). Removed 8144245 from @bug in WriteAfterAbort as \
> > it is now present in WriteToSequenceAfterAbort.
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html \
charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; -webkit-line-break: after-white-space;">The pre-existing WriteAfterAbort \
passes for all plugins; WriteToSequenceAfterAbort passes for TIFF but fails for GIF \
and JPEG, which are the only other plugins which can write sequences. This could be a \
problem in the test itself but I did not investigate further.<div><br></div><div>I \
see also that I need to delete lines 204-206 \
of WriteToSequenceAfterAbort.java.</div><div><br></div><div>Brian<br><div><br><div><div>On \
Dec 7, 2015, at 6:29 PM, Phil Race <<a \
href="mailto:philip.race@oracle.com">philip.race@oracle.com</a>> wrote:</div><br \
class="Apple-interchange-newline"><blockquote type="cite"><div style="font-family: \
Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: \
normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: \
start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; \
word-spacing: 0px; -webkit-text-stroke-width: 0px;">I suppose this modified test must \
pass for all the plugins ? <br><br></div><blockquote type="cite" \
style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: \
normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: \
auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; \
widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div><a \
href="http://cr.openjdk.java.net/~bpb/8144245/webrev.01/">http://cr.openjdk.java.net/~bpb/8144245/webrev.01/</a></div><div><br></div><div><ol \
class="MailOutline"><li>Added WriteToSequenceAfterAbort test.</li><li>Corrected \
TIFFImageWriter to pass both tests (needed to save and restore some extra state, \
mainly positions).</li><li>Removed 8144245 from @bug in WriteAfterAbort as it is now \
present in WriteToSequenceAfterAbort.</li></ol></div></blockquote></blockquote></div><br></div></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic