[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8144858: HBShaper.c does not compiler with VS2010
From:       Volker Simonis <volker.simonis () gmail ! com>
Date:       2015-12-08 10:12:48
Message-ID: CA+3eh12BX-EKcRcQ0ZZ1+X8rw6q5ia92F_pTbyFepUweTS99Ag () mail ! gmail ! com
[Download RAW message or body]

Hi Phil,

thanks for fixing this. This hit us as well.
The change looks good, just a small comment:

'prevCluster' doesn't seems to be used anywhere, so I think you can
completely remove it.

Regards,
Volker


On Mon, Dec 7, 2015 at 8:52 PM, Philip Race <philip.race@oracle.com> wrote:
> Bug : https://bugs.openjdk.java.net/browse/JDK-8144858
> Fix  : http://cr.openjdk.java.net/~prr/8144858/
>
> The inline declarations do not build with VS2010.
> Although VS2013 is the official compiler, I see no reason we
> should not support VS2010 as long as possible.
>
> -phil.
>
[prev in list] [next in list] [prev in thread] [next in thread]