[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] Review Request: Small tweak in the DrawImage.java
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2015-11-17 16:20:27
Message-ID: 564B53CB.7030907 () oracle ! com
[Download RAW message or body]

Bug filed:
8143150: DrawImagePipe can skip some unnecessary blits
https://bugs.openjdk.java.net/browse/JDK-8143150

On 13.11.15 23:43, Jim Graham wrote:
> Looks good!
> 
> ...jim
> 
> On 11/13/2015 12:12 PM, Sergey Bylokhov wrote:
> > On 13.11.15 1:50, Jim Graham wrote:
> > > > I can add a comment that this code is for performance, what do you
> > > > think?
> > > 
> > > I'd like to see that, was there an updated diff?  In either case, I
> > > don't think we should disturb the comment and test at the top, we should
> > > just add additional checks down below where you have them now...
> > 
> > The code for w/h was reverted. Probably I will try change it later in
> > another fix, after verification of our java blits and the fix for
> > JDK-4783274.
> > 
> > http://cr.openjdk.java.net/~serb/perf/DrawImageItself.02/src/java.desktop/share/classes/sun/java2d/pipe/DrawImage.java.sdiff.html
> >  
> > 
> > 


-- 
Best regards, Sergey.


[prev in list] [next in list] [prev in thread] [next in thread]