[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-7161283: [macosx]filedialog didn't pop up for awt test InvalidParam
From: Rajeev Chamyal <rajeev.chamyal () oracle ! com>
Date: 2015-11-06 8:53:17
Message-ID: 38fd1bf6-15cc-4ab3-b692-73e9bc9edda7 () default
[Download RAW message or body]
The fix looks good to me.
Regards,
Rajeev Chamyal
Subject:
Re: [9] RFR JDK-7161283: [macosx]filedialog didn't pop up for awt test \
InvalidParametersNativeTest
Date:
Thu, 5 Nov 2015 12:59:32 +0300
From:
Sergey Bylokhov HYPERLINK \
"mailto:Sergey.Bylokhov@oracle.com"<Sergey.Bylokhov@oracle.com>
To:
prasanta sadhukhan HYPERLINK \
"mailto:prasanta.sadhukhan@oracle.com"<prasanta.sadhukhan@oracle.com>, HYPERLINK \
"mailto:2d-dev@openjdk.java.net"2d-dev@openjdk.java.net HYPERLINK \
"mailto:2d-dev@openjdk.java.net"<2d-dev@openjdk.java.net>, Alexander HYPERLINK \
"mailto:alexandr.scherbatiy@oracle.com"<alexandr.scherbatiy@oracle.com>
The fix looks fine to me.
On 09.10.15 10:04, prasanta sadhukhan wrote:
> Hi All,
>
> Please review a fix for jdk9
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-7161283
> webrev: http://cr.openjdk.java.net/~psadhukhan/7161283/webrev.00/
>
> The bug mentioned that FileDialog is not shown when "Print" button in
> applet is pressed (when "Print to File" is being tested) where "ok/save"
> option will be shown.
> But in standard Apple printer dialog there is no "Print to File" option
> so this filedialog cannot be seen. Rather there is a "PDF" option which
> allows to save the file, so the instructions should be changed in the
> test for Mac.
>
> However, while investigating this problem, I found that there is a NPE
> when no printer is added to the system so PrinterJob.getPrintService()
> returns null but copyAttributes() uses this printService object to check
> supported category attributes without checking if the object is null or
> not. Added the relevant check in PrintJob.
>
> Regards
> Prasanta
--
Best regards, Sergey.
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-IN link=blue \
vlink=purple><div class=WordSection1><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>The \
fix looks good to me.<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Regards,<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Rajeev \
Chamyal<o:p></o:p></span></p><div><p class=MsoNormal> <o:p></o:p></p><table \
class=MsoNormalTable border=0 cellspacing=0 cellpadding=0><tr><td nowrap valign=top \
style='padding:0cm 0cm 0cm 0cm'><p class=MsoNormal align=right \
style='text-align:right'><b>Subject: <o:p></o:p></b></p></td><td style='padding:0cm \
0cm 0cm 0cm'><p class=MsoNormal>Re: [9] RFR JDK-7161283: [macosx]filedialog didn't \
pop up for awt test InvalidParametersNativeTest<o:p></o:p></p></td></tr><tr><td \
nowrap valign=top style='padding:0cm 0cm 0cm 0cm'><p class=MsoNormal align=right \
style='text-align:right'><b>Date: <o:p></o:p></b></p></td><td style='padding:0cm 0cm \
0cm 0cm'><p class=MsoNormal>Thu, 5 Nov 2015 12:59:32 \
+0300<o:p></o:p></p></td></tr><tr><td nowrap valign=top style='padding:0cm 0cm 0cm \
0cm'><p class=MsoNormal align=right style='text-align:right'><b>From: \
<o:p></o:p></b></p></td><td style='padding:0cm 0cm 0cm 0cm'><p class=MsoNormal>Sergey \
Bylokhov <a href="mailto:Sergey.Bylokhov@oracle.com"><Sergey.Bylokhov@oracle.com></a><o:p></o:p></p></td></tr><tr><td \
nowrap valign=top style='padding:0cm 0cm 0cm 0cm'><p class=MsoNormal align=right \
style='text-align:right'><b>To: <o:p></o:p></b></p></td><td style='padding:0cm 0cm \
0cm 0cm'><p class=MsoNormal>prasanta sadhukhan <a \
href="mailto:prasanta.sadhukhan@oracle.com"><prasanta.sadhukhan@oracle.com></a>, \
<a href="mailto:2d-dev@openjdk.java.net">2d-dev@openjdk.java.net</a> <a \
href="mailto:2d-dev@openjdk.java.net"><2d-dev@openjdk.java.net></a>, Alexander \
<a href="mailto:alexandr.scherbatiy@oracle.com"><alexandr.scherbatiy@oracle.com></a><o:p></o:p></p></td></tr></table><p \
class=MsoNormal style='margin-bottom:12.0pt'><o:p> </o:p></p><pre>The fix looks \
fine to me.<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>On 09.10.15 10:04, \
prasanta sadhukhan wrote:<o:p></o:p></pre><pre>> Hi \
All,<o:p></o:p></pre><pre>><o:p> </o:p></pre><pre>> Please review a fix \
for jdk9<o:p></o:p></pre><pre>><o:p> </o:p></pre><pre>> Bug: <a \
href="https://bugs.openjdk.java.net/browse/JDK-7161283">https://bugs.openjdk.java.net/browse/JDK-7161283</a><o:p></o:p></pre><pre>> \
webrev: <a href="http://cr.openjdk.java.net/~psadhukhan/7161283/webrev.00/">http://cr. \
openjdk.java.net/~psadhukhan/7161283/webrev.00/</a><o:p></o:p></pre><pre>><o:p> </o:p></pre><pre>> \
The bug mentioned that FileDialog is not shown when "Print" button \
in<o:p></o:p></pre><pre>> applet is pressed (when "Print to File" is \
being tested) where "ok/save"<o:p></o:p></pre><pre>> option will be \
shown.<o:p></o:p></pre><pre>> But in standard Apple printer dialog there is no \
"Print to File" option<o:p></o:p></pre><pre>> so this filedialog cannot \
be seen. Rather there is a "PDF" option which<o:p></o:p></pre><pre>> \
allows to save the file, so the instructions should be changed in \
the<o:p></o:p></pre><pre>> test for \
Mac.<o:p></o:p></pre><pre>><o:p> </o:p></pre><pre>> However, while \
investigating this problem, I found that there is a NPE<o:p></o:p></pre><pre>> \
when no printer is added to the system so \
PrinterJob.getPrintService()<o:p></o:p></pre><pre>> returns null but \
copyAttributes() uses this printService object to check<o:p></o:p></pre><pre>> \
supported category attributes without checking if the object is null \
or<o:p></o:p></pre><pre>> not. Added the relevant check in \
PrintJob.<o:p></o:p></pre><pre>><o:p> </o:p></pre><pre>> \
Regards<o:p></o:p></pre><pre>> \
Prasanta<o:p></o:p></pre><pre><o:p> </o:p></pre><pre><o:p> </o:p></pre><pre>-- \
<o:p></o:p></pre><pre>Best regards, Sergey.<o:p></o:p></pre><p \
class=MsoNormal><o:p> </o:p></p></div><p \
class=MsoNormal><o:p> </o:p></p></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic