[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8020448: Test closed/java/awt/font/JNICheck/JNICheck.sh fails on S
From: Rajeev Chamyal <rajeev.chamyal () oracle ! com>
Date: 2015-11-04 9:11:33
Message-ID: 667d63f4-4803-4085-9077-790509fcfdd3 () default
[Download RAW message or body]
Looks ok to me.
Regards,
Rajeev Chamyal
Subject:
Re: [9] RFR: JDK-8020448: Test closed/java/awt/font/JNICheck/JNICheck.sh fails on \
Solaris 11
Date:
Mon, 2 Nov 2015 16:17:15 +0300
From:
Alexander Zvegintsev HYPERLINK \
"mailto:alexander.zvegintsev@oracle.com"<alexander.zvegintsev@oracle.com>
To:
prasanta sadhukhan HYPERLINK \
"mailto:prasanta.sadhukhan@oracle.com"<prasanta.sadhukhan@oracle.com>, HYPERLINK \
"mailto:2d-dev@openjdk.java.net"2d-dev@openjdk.java.net HYPERLINK \
"mailto:2d-dev@openjdk.java.net"<2d-dev@openjdk.java.net>, Phil Race HYPERLINK \
"mailto:philip.race@oracle.com"<philip.race@oracle.com>
Looks good to me.
Thanks,
Alexander.
On 10/29/2015 12:06 PM, prasanta sadhukhan wrote:
Hi All,
Please review a small fix in jdk9 whereby JNICheck issued a warning that Exception is \
not checked after calling a JNI method. This is in continuation to HYPERLINK \
"https://bugs.openjdk.java.net/browse/JDK-8130507"JDK-8130507 fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8020448
webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epsadhukhan/8020448/webrev.00/"http://cr.openjdk.java.net/~psadhukhan/8020448/webrev.00/
It was seen that JNICheck was issuing a warning
WARNING in native method: JNI call made without checking exceptions when required to \
from CallBooleanMethod at sun.awt.FcFontManager.getFontPathNative(Native Method)
resulting in failure of this test.
There is another warning raised which is in core-libs code and a bug has been raised \
against it HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8131136"8131136
Fix is to add the proper Exception check.
Regards
Prasanta
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.issue-link-key
{mso-style-name:issue-link-key;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-IN link=blue \
vlink=purple><div class=WordSection1><p class=MsoNormal><span \
style='color:#1F497D'>Looks ok to me.<o:p></o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'>Regards,<o:p></o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'>Rajeev Chamyal<o:p></o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'><o:p> </o:p></span></p><table class=MsoNormalTable \
border=0 cellspacing=0 cellpadding=0><tr><td nowrap valign=top style='padding:0cm 0cm \
0cm 0cm'><p class=MsoNormal align=right style='text-align:right'><b>Subject: \
<o:p></o:p></b></p></td><td style='padding:0cm 0cm 0cm 0cm'><p class=MsoNormal>Re: \
[9] RFR: JDK-8020448: Test closed/java/awt/font/JNICheck/JNICheck.sh fails on Solaris \
11<o:p></o:p></p></td></tr><tr><td nowrap valign=top style='padding:0cm 0cm 0cm \
0cm'><p class=MsoNormal align=right style='text-align:right'><b>Date: \
<o:p></o:p></b></p></td><td style='padding:0cm 0cm 0cm 0cm'><p class=MsoNormal>Mon, 2 \
Nov 2015 16:17:15 +0300<o:p></o:p></p></td></tr><tr><td nowrap valign=top \
style='padding:0cm 0cm 0cm 0cm'><p class=MsoNormal align=right \
style='text-align:right'><b>From: <o:p></o:p></b></p></td><td style='padding:0cm 0cm \
0cm 0cm'><p class=MsoNormal>Alexander Zvegintsev <a \
href="mailto:alexander.zvegintsev@oracle.com"><alexander.zvegintsev@oracle.com></a><o:p></o:p></p></td></tr><tr><td \
nowrap valign=top style='padding:0cm 0cm 0cm 0cm'><p class=MsoNormal align=right \
style='text-align:right'><b>To: <o:p></o:p></b></p></td><td style='padding:0cm 0cm \
0cm 0cm'><p class=MsoNormal>prasanta sadhukhan <a \
href="mailto:prasanta.sadhukhan@oracle.com"><prasanta.sadhukhan@oracle.com></a>, \
<a href="mailto:2d-dev@openjdk.java.net">2d-dev@openjdk.java.net</a> <a \
href="mailto:2d-dev@openjdk.java.net"><2d-dev@openjdk.java.net></a>, Phil Race \
<a href="mailto:philip.race@oracle.com"><philip.race@oracle.com></a><o:p></o:p></p></td></tr></table><p \
class=MsoNormal><br><br>Looks good to \
me.<br><br><o:p></o:p></p><pre>Thanks,<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>Alexander.<o:p></o:p></pre><div><p \
class=MsoNormal>On 10/29/2015 12:06 PM, prasanta sadhukhan \
wrote:<o:p></o:p></p></div><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal>Hi All,<br><br>Please \
review a small fix in jdk9 whereby JNICheck issued a warning that Exception is not \
checked after calling a JNI method.<br>This is in continuation to <a \
href="https://bugs.openjdk.java.net/browse/JDK-8130507" id=key-val>JDK-8130507</a> \
fix.<br><br>Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8020448">https://bugs.openjdk.java.net/browse/JDK-8020448</a><br>webrev: \
<a href="http://cr.openjdk.java.net/%7Epsadhukhan/8020448/webrev.00/">http://cr.openjdk.java.net/~psadhukhan/8020448/webrev.00/</a><br><br>It \
was seen that JNICheck was issuing a warning<br>WARNING in native method: JNI call \
made without checking exceptions when required to from \
CallBooleanMethod<br> at \
sun.awt.FcFontManager.getFontPathNative(Native Method)<br>resulting in failure of \
this test.<br>There is another warning raised which is in core-libs code and a bug \
has been raised against it <a \
href="https://bugs.openjdk.java.net/browse/JDK-8131136"><span \
class=issue-link-key>8131136</span></a><br><br>Fix is to add the proper Exception \
check.<br><br>Regards<br>Prasanta<o:p></o:p></p></blockquote><p class=MsoNormal \
style='margin-bottom:12.0pt'><o:p> </o:p></p><p \
class=MsoNormal><o:p> </o:p></p></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic