[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9]: RFR JDK-8023213 [macosx] closed/java/awt/FontClass/NaNTransform.java fails
From:       Phil Race <philip.race () oracle ! com>
Date:       2015-10-29 19:33:12
Message-ID: 56327478.1060105 () oracle ! com
[Download RAW message or body]

Should this new check go before this :

CGGI_ClearCanvas(canvas, info);

since it is using info which is where you get NaN from.


And should we then populate the returned canvas and info to
ensure that we return an "empty" glyph rather than garbage values ?
It is not clear to me that this is occurring.

Why does the bug report not contain the evaluation below ?
Also why is there a new test ? I would expect SQE would
want to run the existing test to verify this fix.
Should we not just open the existing test ?


-phil.

On 10/13/2015 04:49 AM, prasanta sadhukhan wrote:
> Gentle reminder for review
>
> Regards
> Prasanta
> On 10/6/2015 3:25 PM, prasanta sadhukhan wrote:
>> Hello All,
>>
>> Please review a fix for jdk9
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8023213
>> webrev: http://cr.openjdk.java.net/~psadhukhan/8023213/webrev.00/
>>
>> drawString takes long time in mac native call 
>> CGContextShowGlyphsAtPoint() if NaN transform is used which 
>> translated to x & y being NaN.
>> Fix is to prevent calling mac api for such invalid usage.
>>
>> Regards
>> Prasanta
>

[prev in list] [next in list] [prev in thread] [next in thread]