[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: Typo in makefile changes for 8043805 [Allow using a system-installed libjp
From:       Erik Joelsson <erik.joelsson () oracle ! com>
Date:       2015-10-27 8:22:42
Message-ID: 562F3452.80102 () oracle ! com
[Download RAW message or body]

Looks good to me.

/Erik

On 2015-10-26 18:30, Omair Majid wrote:
> (moving from jdk9-dev)
>
> Hi,
>
> I have created a webrev at:
> http://cr.openjdk.java.net/~omajid/webrevs/8139932-typo-makefile-jpeg/00/
>
> Typo in makefile changes for 8043805 [Allow using a system-installed libjpeg]
> Reviewed-by: omajid, prr
> Contributed-by: Matthias Klose <doko@ubuntu.com>
>
> Regards,
> Omair
>
> * Philip Race <philip.race@oracle.com> [2015-10-19 17:22]:
>> I filed https://bugs.openjdk.java.net/browse/JDK-8139932
>>
>> -phil.
>>
>> On 10/19/15, 12:51 PM, Matthias Klose wrote:
>>> till seen with b87.  The current makefile has a typo, referencing the
>>> wrong file.
>>>
>>> Please create a ticket and a webrev. I don't have access to these tools.
>>>
>>> Matthias
>>>
>>> libjpeg-fix.diff
>>>
>>>
>>> # DP: Fix libjavajpeg build using the system jpeg library.
>>>
>>> Index: b/jdk/make/lib/Awt2dLibraries.gmk
>>> ===================================================================
>>> --- a/jdk/make/lib/Awt2dLibraries.gmk
>>> +++ b/jdk/make/lib/Awt2dLibraries.gmk
>>> @@ -476,7 +476,7 @@ endif
>>>   ifeq ($(USE_EXTERNAL_LIBJPEG), true)
>>>     LIBJPEG_LIBS := -ljpeg
>>>     BUILD_LIBJAVAJPEG_INCLUDE_FILES := \
>>> -      imageIOJPEG.c \
>>> +      imageioJPEG.c \
>>>         jpegdecoder.c
>>>     BUILD_LIBJAVAJPEG_HEADERS :=
>>>   else

[prev in list] [next in list] [prev in thread] [next in thread]