[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [9] RFR JDK-8072682: getBounds call on graphics.getDeviceConfiguration() return
From:       Jim Graham <james.graham () oracle ! com>
Date:       2015-10-12 17:38:45
Message-ID: 561BF025.7030301 () oracle ! com
[Download RAW message or body]

Looks good!

		...jim

On 10/11/15 10:59 PM, prasanta sadhukhan wrote:
> Thanks for the review.
> I have removed the unused fields.
> Here's the modified webrev:
> http://cr.openjdk.java.net/~psadhukhan/8072682/webrev.01/
>
> Hi Sergey, can you commit this fix?
>
> Regards
> Prasanta
> On 10/10/2015 2:02 AM, Jim Graham wrote:
>> +1 for the fix and removing the fields.
>>
>>         ...jim
>>
>> On 10/9/15 8:37 AM, Sergey Bylokhov wrote:
>>> Hi, Prasanta.
>>> It seems that width&height fields are not used after the fix and can be
>>> removed.
>>>
>>> On 08.10.15 11:12, prasanta sadhukhan wrote:
>>>> Hi All,
>>>>
>>>> Please review a fix for jdk9
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8072682
>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8072682/webrev.00/
>>>>
>>>> BufferedImageGraphicsConfig creates a cache to store the BufferedImage
>>>> information but it was found that the cache shares the
>>>> GraphicsConfiguration across images of the same type,
>>>> so for different images of same type, the first stored information is
>>>> returned when getBounds() is queried.
>>>> The consensus is instead of adding image bounds info to the cache, let
>>>> the deviceConfig.getBounds() returns the MAXINT bounds.
>>>>
>>>> Regards
>>>> Prasanta
>>>>
>>>
>>>
>
[prev in list] [next in list] [prev in thread] [next in thread]