[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: [9] JDK-8076540[macosx] NPE due to incorrect threading
From:       Alexander Zvegintsev <alexander.zvegintsev () oracle ! com>
Date:       2015-09-30 10:22:20
Message-ID: 560BB7DC.6030401 () oracle ! com
[Download RAW message or body]

The fix looks OK to me.

Thanks,

Alexander.

On 09/30/2015 11:32 AM, Alexander Scherbatiy wrote:
>
>
>   The fix looks good to me.
>
> On 9/30/2015 8:23 AM, prasanta sadhukhan wrote:
>> Hi Alexandr,
>>
>> It's the same fix that you approved in crucible
>
>   This is the open alias and it is always good to have a history of 
> the fix here as well.
>
>   Thanks,
>   Alexandr.
>
>> ie, move the instruction to constructor from applet init() so that 
>> "dialog" gets initialised properly. The crash was because dialog was 
>> not initialised but dialog.displayMessage() was called.
>>
>> Regards
>> Prasanta
>> On 9/29/2015 6:50 PM, Alexander Scherbatiy wrote:
>>> On 9/29/2015 8:25 AM, prasanta sadhukhan wrote:
>>>> Gentle reminder to approve and commit this change.
>>>
>>>    Could you describe which changes were made in the fix?
>>>
>>>    Thanks,
>>>    Alexandr.
>>>>
>>>> Regards
>>>> Prasanta
>>>> On 9/28/2015 4:55 PM, prasanta sadhukhan wrote:
>>>>> Hi Alexander,
>>>>>
>>>>> Can this please be approved and committed please since this is 
>>>>> already approved in crucible?
>>>>>
>>>>> Regards
>>>>> Prasanta
>>>>> On 9/25/2015 12:21 PM, prasanta sadhukhan wrote:
>>>>>> Hi All,
>>>>>>
>>>>>> Please review addition of this fixed test in open (moved from 
>>>>>> closed)
>>>>>>
>>>>>>  Bug: https://bugs.openjdk.java.net/browse/JDK-8076540
>>>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8076540/webrev/
>>>>>>
>>>>>> The review request for fix in this closed test was raised 
>>>>>> internally and approved.
>>>>>>
>>>>>> Regards
>>>>>> Prasanta
>>>>>
>>>>
>>>
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]