[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] <AWT Dev> RFR: 8136783: Run blessed-modifier-order script on java.desktop
From:       Alexandr Scherbatiy <alexandr.scherbatiy () oracle ! com>
Date:       2015-09-21 8:31:48
Message-ID: 55FFC074.2030203 () oracle ! com
[Download RAW message or body]


The fix looks good to me.

Thanks,
Alexandr.

19.09.2015 23:14, Sergey Bylokhov пишет:
> Looks fine. Thanks!
>
> On 19.09.15 22:39, Phil Race wrote:
>> Let me do that as separate review. There are also demos and tests do 
>> this is not the last of it anyway but this is a big one to get out of 
>> the way
>>
>> -Phil.
>>
>>> On Sep 19, 2015, at 12:01 PM, Sergey Bylokhov 
>>> <Sergey.Bylokhov@oracle.com> wrote:
>>>
>>> Hi, Phil.
>>>>
>>>>
>>>> What I am updating here is all the files under src/java.desktop which
>>>> is a decent-sized chunk.: 324 files. I recommend looking at the
>>>> jdk.patch file
>>>
>>> What about src/java.datatransfer module?(it was extracted from desktop)
>>>
>>>>
>>>> I have checked the changes myself visually but also used JPRT to
>>>> make sure that no introduced syntax error causes a build failure.
>>>>
>>>> Separately 2 minor changes to closed source files have been sent for
>>>> internal review.
>>>>
>>>> -phil.
>>>
>>>
>>> -- 
>>> Best regards, Sergey.
>
>

[prev in list] [next in list] [prev in thread] [next in thread]