[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] <Swing Dev> JDK 9 RFR of JDK-8129822: Define "headful" jtreg keyword
From:       Alexander Scherbatiy <alexandr.scherbatiy () oracle ! com>
Date:       2015-06-25 10:13:16
Message-ID: 558BD43C.8060604 () oracle ! com
[Download RAW message or body]

On 6/25/2015 2:42 AM, joe darcy wrote:
> Hello,
>
> To support the next iteration of tiered testing in JDK 9, with an eye 
> toward running client library tests, please review the patch below 
> which addresses
>
>     JDK-8129822: Define "headful" jtreg keyword
>
> Some test environments are headless, including test environments often 
> used for the tier 1 and tier 2 tests. The jdk_desktop test group is 
> defined as follows:
>
> jdk_desktop = \
>     :jdk_awt \
>     :jdk_2d \
>     :jdk_beans \
>     :jdk_swing \
>     :jdk_sound \
>     :jdk_imageio
>
> Of those constituent test groups, nearly all of the tests in 
> jdk_beans, jdk_sound, and jdk_imageio can be successfully run in a 
> *headless* environment. Therefore, I'd like to be able to tag the 
> handful of tests that need a head with "@key headful"  so they can be 
> excluded from test runs in a headless environment.
>
> Future changesets will add the keyword to the appropriate tests.
>
> Thanks,
>
> -Joe
>
> diff -r db09207cc779 test/TEST.ROOT
> --- a/test/TEST.ROOT    Wed Jun 24 15:15:10 2015 -0700
> +++ b/test/TEST.ROOT    Wed Jun 24 16:33:09 2015 -0700
> @@ -8,8 +8,11 @@
>  # would not count as "randomness" by this definition.) Extra care
>  # should be taken to handle test failures of intermittent or
>  # randomness tests.
> +#
> +# A "headful" test requires a graphical environment to meaningfully
> +# run. Tests that are not headful are "headless."
>
> -keys=2d dnd i18n intermittent randomness
> +keys=2d dnd i18n intermittent randomness headful
>
>  # Tests that must run in othervm mode
>  othervm.dirs=java/awt java/beans javax/accessibility javax/imageio 
> javax/sound javax/print javax/management com/sun/awt sun/awt 
> sun/java2d sun/pisces javax/xml/jaxp/testng/validation 
> java/lang/ProcessHandle
>

  The fix looks good to me.

  Thanks,
  Alexandr.
[prev in list] [next in list] [prev in thread] [next in thread]