[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] review backport fix of 8081756 to 8u-dev
From:       Andrew Brygin <andrew.brygin () oracle ! com>
Date:       2015-06-11 7:45:59
Message-ID: 55793CB7.1050505 () oracle ! com
[Download RAW message or body]

Hello Phil,

  the backport looks fine to me.

Thanks,
Andrew

On 6/10/2015 11:25 PM, Phil Race wrote:
> Andrew/Sergey,
>
> Could one of you please be a 'sanity check' backport reviewer on
> this backport of a missing check for NULL in LittleCMS code.
>
> It is identical to the JDK 9 changeset : - 
> http://hg.openjdk.java.net/jdk9/client/jdk/rev/80e814d165f9
>
> BTW I already sent that to upstream ..
>
> diff --git a/src/share/native/sun/java2d/cmm/lcms/cmsopt.c 
> b/src/share/native/sun/java2d/cmm/lcms/cmsopt.c
> --- a/src/share/native/sun/java2d/cmm/lcms/cmsopt.c
> +++ b/src/share/native/sun/java2d/cmm/lcms/cmsopt.c
> @@ -260,7 +260,9 @@
>                              cmsStage* Multmat = 
> cmsStageAllocMatrix(Lut->ContextID, 3, 3, (const cmsFloat64Number*) 
> &res, NULL);
>
>                              // Recover the chain
> +                            if (Multmat != NULL) {
>                              Multmat->Next = chain;
> +                            }
>                              *pt1 = Multmat;
>                       }
>
> -phil.

[prev in list] [next in list] [prev in thread] [next in thread]